Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

olevba: detect and display special characters such as backspace #358

Closed
decalage2 opened this issue Oct 8, 2018 · 2 comments
Closed

olevba: detect and display special characters such as backspace #358

decalage2 opened this issue Oct 8, 2018 · 2 comments
Assignees
Milestone

Comments

@decalage2
Copy link
Owner

@decalage2 decalage2 commented Oct 8, 2018

Stan Hegt (@stanhegt) and Pieter Ceelen (@pieterceelen) have found an issue with olevba: Some special characters such as backspace may be inserted into the VBA source code or comments, to manipulate what is displayed on the console by olevba:

Solution:

  • olevba should detect special characters in the VBA code before displaying them on the console, and replace them with something printable such as \x08 for backspace. They could be colored in red using colorclass. This should not be applied to VBA code returned by the python API, since the issue only applies to console output.
  • When special characters are detected, an additional indicator should be added to the list, since this is not expected in normal VBA code.
@decalage2 decalage2 added this to the oletools 0.54 milestone Oct 8, 2018
@decalage2 decalage2 self-assigned this Oct 8, 2018
decalage2 added a commit that referenced this issue Oct 8, 2018
decalage2 added a commit that referenced this issue Oct 9, 2018
…eported as suspicious (issue #358)
decalage2 added a commit that referenced this issue Oct 9, 2018
@decalage2 decalage2 closed this Oct 9, 2018
@decalage2

This comment has been minimized.

Copy link
Owner Author

@decalage2 decalage2 commented Oct 9, 2018

This also needs to be added to olevba3, of course.

@decalage2 decalage2 reopened this Oct 9, 2018
@decalage2

This comment has been minimized.

Copy link
Owner Author

@decalage2 decalage2 commented Mar 15, 2019

olevba3 is now merged with olevba.

@decalage2 decalage2 closed this Mar 15, 2019
decalage2 added a commit that referenced this issue Apr 4, 2019
…se positive detection of backspace chars (issue #358)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.