Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

olevba: test if Aho-Corasick is applicable and faster than simple string search #633

Open
decalage2 opened this issue Oct 14, 2020 · 0 comments
Assignees

Comments

@decalage2
Copy link
Owner

olevba looks for many strings in VBA source code, XLM, and P-code. The Aho-Corasick algorithm is meant for that, so it might be faster than the current implementation, which simply searches strings one by one.
However, olevba uses regex for the searches to find word boundaries, so maybe Aho-Corasick cannot be used as-is.
Potential candidates:

On the other hand, for now olevba search looks fast enough most of the time, so this would only be needed if we experience performance issues for some samples, or if someone uses olevba to process many samples at large scale.

@decalage2 decalage2 added this to the Future Releases milestone Oct 14, 2020
@decalage2 decalage2 self-assigned this Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant