Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cookies #335

Merged
merged 3 commits into from Jun 13, 2022
Merged

Remove cookies #335

merged 3 commits into from Jun 13, 2022

Conversation

adamgall
Copy link
Contributor

In Draft status until #332 is merged, since this PR builds on that one.


Implementing the Favorites PR (#332) made me realize that I should be using Local Storage for arbitrary local storage, not cookies.

So, this PR replaces the "not audited" acceptance state management from being cookie-based to LocalStorage-based.

@adamgall adamgall self-assigned this Jun 10, 2022
@netlify
Copy link

netlify bot commented Jun 10, 2022

Deploy Preview for fractal-framework-interface-dev ready!

Name Link
🔨 Latest commit 7f78590
🔍 Latest deploy log https://app.netlify.com/sites/fractal-framework-interface-dev/deploys/62a2e5900a08330009d7ef73
😎 Deploy Preview https://deploy-preview-335--fractal-framework-interface-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@adamgall adamgall changed the base branch from develop to favorites June 10, 2022 06:33
@adamgall adamgall marked this pull request as ready for review June 10, 2022 06:34
@adamgall adamgall marked this pull request as draft June 10, 2022 06:34
Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. this update make sense. Approval pending Draft -> Ready for Review

Base automatically changed from favorites to develop June 13, 2022 13:24
@adamgall adamgall marked this pull request as ready for review June 13, 2022 13:25
@adamgall adamgall merged commit b5a430b into develop Jun 13, 2022
@adamgall adamgall deleted the remove-cookies branch June 13, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants