Skip to content
This repository has been archived by the owner. It is now read-only.

Add test for Windows with AppVeyor #136

Merged

Conversation

Projects
None yet
2 participants
@matsubara0507
Copy link
Collaborator

commented Feb 25, 2018

about #127
I wrote appveyor.yml with reference to this file.

but, test fail on Windows:
https://ci.appveyor.com/project/matsubara0507/tasty-discover/build/1.0.5#L473

modules
    Test discovery
      Discovers tests:                                           FAIL
        expected [Test {testModule = "PropTest", testFunction = "prop_additionAssociative"},Test {testModule = "SubSubMod/PropTest", testFunction = "prop_additionCommutative"}], but got [Test {testModule = "PropTest", testFunction = "prop_additionAssociative"},Test {testModule = "SubSubMod.PropTest", testFunction = "prop_additionCommutative"}]

Reason is that use pathSeparator on mkTest .
So, fixed it by using isPathSeparator .
ref: https://ci.appveyor.com/project/matsubara0507/tasty-discover/build/1.0.6

matsubara0507 added some commits Feb 25, 2018

Fix: test on windows
Test `Discovers tests` fail because `pathSeparator` is only '\\' on Windows.
@decentral1se

This comment has been minimized.

Copy link
Owner

commented Feb 25, 2018

Oh damn, this is really awesome @matsubara0507 🌈 🌈 🌈

Thanks a lot!

I've enabled AppVeyor builds from my account, gonna open/close and see if it runs.

@decentral1se

This comment has been minimized.

@decentral1se decentral1se merged commit e3830a2 into decentral1se:master Feb 25, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@decentral1se

This comment has been minimized.

Copy link
Owner

commented Feb 25, 2018

Making a point release on this from #137 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.