From 603b5e4c601ddf65c5336a670b392e6e0f0942e7 Mon Sep 17 00:00:00 2001
From: Fernando Zavalia <24811313+fzavalia@users.noreply.github.com>
Date: Thu, 7 Oct 2021 15:24:50 -0300
Subject: [PATCH] chore: Enable coverall and remove stub test (#302)

* chore: Enable coverall and remove stub test

* chore: Comment coverall

* chore: Uncomment coverall

* chore: Change checkout and setup to v2

* chore: Add cache to actions
---
 .github/workflows/node.yml | 22 ++++++++++------------
 src/DELETE_ME.spec.ts      | 11 -----------
 2 files changed, 10 insertions(+), 23 deletions(-)
 delete mode 100644 src/DELETE_ME.spec.ts

diff --git a/.github/workflows/node.yml b/.github/workflows/node.yml
index 9f2429d7..13a8d936 100644
--- a/.github/workflows/node.yml
+++ b/.github/workflows/node.yml
@@ -6,19 +6,19 @@ jobs:
   Tests:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@master
-      - name: Use Node.js 14.x
-        uses: actions/setup-node@v1
+      - name: Checkout Code
+        uses: actions/checkout@v2
+      - name: Use Node.js 14
+        uses: actions/setup-node@v2
         with:
-          node-version: 14.x
+          node-version: '14'
+          cache: 'npm'
       - name: Install
         run: npm ci
       - name: Test
         run: npm run test:coverage
         if: ${{ always() }}
         env:
-          # Variables required to run tests as they all break
-          # execution if they are not defined
           AWS_ACCESS_KEY: AWS_ACCESS_KEY
           AWS_ACCESS_SECRET: AWS_ACCESS_SECRET
           AWS_BUCKET_NAME: AWS_BUCKET_NAME
@@ -29,9 +29,7 @@ jobs:
           DEFAULT_ETH_ADDRESS: DEFAULT_ETH_ADDRESS
           ANALYTICS_CONNECTION_STRING: ANALYTICS_CONNECTION_STRING
           PEER_URL: https://peer.decentraland.zone
-      # # Not working right now because of the lack of tests
-      # # Uncomment when more are added
-      # - name: report coverage
-      #   uses: coverallsapp/github-action@master
-      #   with:
-      #     github-token: ${{ secrets.GITHUB_TOKEN }}
+      - name: Report Coverage
+        uses: coverallsapp/github-action@master
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
diff --git a/src/DELETE_ME.spec.ts b/src/DELETE_ME.spec.ts
deleted file mode 100644
index d63587d0..00000000
--- a/src/DELETE_ME.spec.ts
+++ /dev/null
@@ -1,11 +0,0 @@
-/**
- * This test exists so that at least 1 test exists inside the repo
- * causing CI not to break
- * Delete this file as soon as more tests are added
- */
-
-it('DELETE ME', () => {
-  expect(1).toBe(1)
-})
-
-export {}