feat: rollback publish changes #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicosantangelo
force-pushed
the
feat/publish-rollback
branch
from
3bbe665
to
4bf2792
Compare
LautaroPetaccio
requested changes
Mar 15, 2022
src/Collection/Collection.service.ts
Outdated
Comment on lines
243
to
255
| SlotUsageCheque.delete({ created_at: now }), | ||
| ItemCuration.delete({ created_at: now }), |
There was a problem hiding this comment.
There are three issues that I see here:
- Although it could be rare, there's no guarantee that there will be only one publication in the same millisecond, as there are operations that could be done in nanoseconds, hitting the same millisecond, possibly deleting things that weren't supposed to be deleted.
- Item curations can be created at any time. Following the same idea as the other point, we could be deleting an item curation that was created in the same millisecond period.
- Having a new instance of the builder will increase the possibility of hitting the same millisecond.
There was a problem hiding this comment.
I thought of all of those (except the last one regretfully) and was expecting some feedback lol. The thing is that deleting itemCurations is a bit of a pain, but I'll try saving the ids and using them here. It'll make the code more complex but I don't see any way around it. Let me know if you do!
nicosantangelo
force-pushed
the
feat/publish-rollback
branch
from
4bf2792
to
f47b8e6
Compare
Pull Request Test Coverage Report for Build 1988953138
💛 - Coveralls |
LautaroPetaccio
requested changes
Mar 16, 2022
| ) | ||
| jest.spyOn(ethers.utils, 'verifyMessage').mockReturnValue('0x') | ||
|
|
||
| jest.spyOn(SlotUsageCheque, 'create').mockResolvedValueOnce({}) |
There was a problem hiding this comment.
Would you mind adding here an id so we can later assert that the delete procedure was called with this id?
There was a problem hiding this comment.
The same goes for the delete method of the SlotUsageCheque.
Comment on lines
1378
to
1380
| let itemCurationDeleteSpy: jest.SpyInstance< | ||
| ReturnType<typeof ItemCuration.delete> | ||
| > |
There was a problem hiding this comment.
With the change, instead of ItemCuration.delete, ItemCuration.deleteByIds is being used.
nicosantangelo
force-pushed
the
feat/publish-rollback
branch
from
3c0868e
to
0d93240
Compare
LautaroPetaccio
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #422