Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

claimForgottenParcel allows anyone to steal "forgotten" parcels #1

Closed
dafky2000 opened this issue Oct 3, 2017 · 1 comment
Closed

claimForgottenParcel allows anyone to steal "forgotten" parcels #1

dafky2000 opened this issue Oct 3, 2017 · 1 comment

Comments

@dafky2000
Copy link

@dafky2000 dafky2000 commented Oct 3, 2017

I am still new to Solidity so forgive me if I missed something obvious but....

In LAND.sol -> claimForgottenParcel there is no verification other than that the token is already owned and it hasn't been pinged in over a year.

Anyone can claim forgotten tokens for free? Or is it supposed to "require(msg.sender == claimContract);"?

@eordano
Copy link
Member

@eordano eordano commented Oct 3, 2017

Thanks! Yes, require(msg.sender == claimContract) as you suggested is the way to go!

@eordano eordano closed this Oct 3, 2017
eordano added a commit that referenced this issue Oct 3, 2017
eordano pushed a commit that referenced this issue Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants