fix: combined avatar mesh leak #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After the CI passes:
|
Kinerius
approved these changes
Sep 21, 2021
| @@ -415,6 +424,10 @@ private IEnumerator LoadAvatar() | |||
| // TODO(Brian): Evaluate using UniTask<T> instead of this way. | |||
| yield return new WaitUntil(() => bodyShapeController.isReady && wearableControllers.Values.All(x => x.isReady)); | |||
|
|
|||
| if ( eyesController == null || eyebrowsController == null || mouthController == null ) | |||
| { | |||
| } | |||
There was a problem hiding this comment.
You might want to delete this
pravusjif
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
How to test the changes?
clientDebug.InstantiateBotsAtCoords({ amount: 200 })clientDebug.ClearBots().Notice that when doing this in
mastera lot of dangling meshes can be seen on Unity's profiler, incurring a leak of around 2.4 mb per avatar.On the version of this PR, the meshes should be destroyed and the memory freed.
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md