Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use multihash throughout code as described by Sidetree protocol #26

Closed
thehenrytsai opened this issue Oct 8, 2018 · 3 comments
Closed

Use multihash throughout code as described by Sidetree protocol #26

thehenrytsai opened this issue Oct 8, 2018 · 3 comments
Assignees
@thehenrytsai
Labels
feature A new implementation feature request protocol Sidetree protocol change proposal

Comments

@thehenrytsai
Copy link
Collaborator

No description provided.

@thehenrytsai thehenrytsai added the feature A new implementation feature request label Oct 8, 2018
@thehenrytsai thehenrytsai self-assigned this Oct 8, 2018
@thehenrytsai thehenrytsai changed the title Use multihash throughout code and documentation as described by Sidetree protocol Use multihash throughout code as described by Sidetree protocol Dec 12, 2018
@thehenrytsai thehenrytsai added the protocol Sidetree protocol change proposal label Mar 28, 2019
@csuwildcat
Copy link
Member

Was this is the thing that degraded perf a lot, related to the base encoding type? I thought I remembered there being some issue with 58 vs 64

@thehenrytsai
Copy link
Collaborator Author

No, this is not. The library we used for base58 encoding was degrading the perf by a lot, but we have since moved away from it to base64url.

@thehenrytsai thehenrytsai mentioned this issue Jul 2, 2019
Closed
@thehenrytsai
Copy link
Collaborator Author

Implemented in 445709a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thehenrytsai thehenrytsai

Labels
feature A new implementation feature request protocol Sidetree protocol change proposal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@csuwildcat @thehenrytsai