Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the code related to questionnaire templates previews #11743

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Simplify the code related to questionnaire templates previews #11743

merged 1 commit into from
Oct 11, 2023

Conversation

ahukkanen
Copy link
Contributor

🎩 What? Why?

This PR simplifies the calls related to the questionnaire templates preview and removes some unnecessary code.

Testing

  • Create the development app
  • Make sure you have a survey template in the templates section (should be created by seeds)
  • Create a new survey component
  • Go to that component and select the template from the list
  • Check that you see the preview rendering of the template

@ahukkanen ahukkanen added module: templates type: fix PRs that implement a fix for a bug labels Oct 11, 2023
alecslupu
alecslupu approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alecslupu alecslupu merged commit 57a4b46 into develop Oct 11, 2023
35 checks passed
@alecslupu alecslupu deleted the fix/simplify-questionnaire-templates-preview branch October 11, 2023 16:47
@alecslupu alecslupu mentioned this pull request Oct 11, 2023
Merged
andreslucena pushed a commit that referenced this pull request Oct 16, 2023
@ahukkanen @andreslucena
Simplify the code related to questionnaire templates previews (#11743)
35a6a31
This was referenced Nov 3, 2023
Merged
Merged
@andreslucena andreslucena mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecslupu alecslupu alecslupu approved these changes

Assignees
No one assigned
Labels
module: templates type: fix PRs that implement a fix for a bug
Projects
Maintainers' backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahukkanen @alecslupu