Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic test for .gemspec sanity #13099

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

ahukkanen
Copy link
Contributor

@ahukkanen ahukkanen commented Jul 8, 2024

🎩 What? Why?

Since I recently noticed some cross dependency issues with the Decidim gem, I added this test to check that the .gemspec files do not define the decidim root gem as their dependency.

This might not fix the whole problem with the individual gems (see #13062) but it's a start to making sure that gems could work without requiring all the other gems as their dependencies.

📌 Related Issues

Testing

@ahukkanen ahukkanen added target: developer-experience type: internal PRs that aren't necessary to add to the CHANGELOG for implementers labels Jul 8, 2024
@ahukkanen ahukkanen marked this pull request as ready for review July 23, 2024 07:56
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied the decidim-dev.gemspec as it was before #13052, and have this:

$ bundle exec rspec spec/gemspecs_spec.rb
.F

Failures:

  1) Gemspec sanity decidim-dev spec does not require the `decidim` gem
     Failure/Error: expect(decidim_dev_spec).to be_decidim_clean
       expected 'decidim-dev' gem not to have the 'decidim' gem as its dependency
     # ./spec/gemspecs_spec.rb:21:in `block (3 levels) in <top (required)>'

Finished in 0.05099 seconds (files took 0.06076 seconds to load)
2 examples, 1 failure

Failed examples:

rspec ./spec/gemspecs_spec.rb:20 # Gemspec sanity decidim-dev spec does not require the `decidim` gem

So, it works as expected. Thanks for the PR!

@andreslucena andreslucena merged commit bcfb7db into decidim:develop Jul 23, 2024
99 checks passed
@ahukkanen ahukkanen deleted the chore/gemspec-sanity branch July 23, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: dev target: developer-experience type: internal PRs that aren't necessary to add to the CHANGELOG for implementers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants