Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize Call To Action button #2053

Merged
merged 5 commits into from Oct 18, 2017
Merged

Customize Call To Action button #2053

merged 5 commits into from Oct 18, 2017

Conversation

@mrcasals
Copy link
Contributor

@mrcasals mrcasals commented Oct 17, 2017

馃帺 What? Why?

This PR lets admins customize the text and path of the Call To Action button in the homepage.

馃搶 Related Issues

馃摲 Screenshots (optional)

With default values (no custom values set):

http://recordit.co/yBjZJZMMv4

Setting custom values:

http://recordit.co/zXgX5PqUNo

@mrcasals mrcasals self-assigned this Oct 17, 2017
@mrcasals mrcasals force-pushed the admin/cta-button-link branch from dbc6b86 to 76d8d57 Oct 17, 2017
@codecov
Copy link

@codecov codecov bot commented Oct 17, 2017

Codecov Report

Merging #2053 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2053      +/-   ##
==========================================
+ Coverage   98.55%   98.55%   +<.01%     
==========================================
  Files        1173     1174       +1     
  Lines       26609    26621      +12     
==========================================
+ Hits        26224    26236      +12     
  Misses        385      385

@mrcasals mrcasals changed the title Admin/cta button link Customize Call To Action button Oct 17, 2017
@xabier
Copy link
Member

@xabier xabier commented Oct 18, 2017

Nice job!

@mrcasals mrcasals force-pushed the admin/cta-button-link branch from 4f84d58 to fb7b766 Oct 18, 2017
@mrcasals mrcasals merged commit cfec121 into master Oct 18, 2017
31 checks passed
@ghost ghost removed the in-review label Oct 18, 2017
@mrcasals mrcasals deleted the admin/cta-button-link branch Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants