Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize Call To Action button #2053

Merged
merged 5 commits into from Oct 18, 2017

Conversation

Projects
None yet
3 participants
@mrcasals
Copy link
Contributor

commented Oct 17, 2017

馃帺 What? Why?

This PR lets admins customize the text and path of the Call To Action button in the homepage.

馃搶 Related Issues

馃摲 Screenshots (optional)

With default values (no custom values set):

http://recordit.co/yBjZJZMMv4

Setting custom values:

http://recordit.co/zXgX5PqUNo

@mrcasals mrcasals added the in-review label Oct 17, 2017

@mrcasals mrcasals self-assigned this Oct 17, 2017

mrcasals added some commits Oct 17, 2017

@mrcasals mrcasals force-pushed the admin/cta-button-link branch from dbc6b86 to 76d8d57 Oct 17, 2017

@codecov

This comment has been minimized.

Copy link

commented Oct 17, 2017

Codecov Report

Merging #2053 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2053      +/-   ##
==========================================
+ Coverage   98.55%   98.55%   +<.01%     
==========================================
  Files        1173     1174       +1     
  Lines       26609    26621      +12     
==========================================
+ Hits        26224    26236      +12     
  Misses        385      385

@mrcasals mrcasals changed the title Admin/cta button link Customize Call To Action button Oct 17, 2017

@xabier

This comment has been minimized.

Copy link
Member

commented Oct 18, 2017

Nice job!

@mrcasals mrcasals force-pushed the admin/cta-button-link branch from 4f84d58 to fb7b766 Oct 18, 2017

@mrcasals mrcasals merged commit cfec121 into master Oct 18, 2017

31 checks passed

ci/circleci: accountability Your tests passed on CircleCI!
Details
ci/circleci: admin Your tests passed on CircleCI!
Details
ci/circleci: api Your tests passed on CircleCI!
Details
ci/circleci: assemblies Your tests passed on CircleCI!
Details
ci/circleci: budgets Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: comments Your tests passed on CircleCI!
Details
ci/circleci: core Your tests passed on CircleCI!
Details
ci/circleci: main Your tests passed on CircleCI!
Details
ci/circleci: meetings Your tests passed on CircleCI!
Details
ci/circleci: pages Your tests passed on CircleCI!
Details
ci/circleci: processes Your tests passed on CircleCI!
Details
ci/circleci: proposals Your tests passed on CircleCI!
Details
ci/circleci: surveys Your tests passed on CircleCI!
Details
ci/circleci: system Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codecov/patch 100% of diff hit (target 50%)
Details
codecov/project 98.55% (+<.01%) compared to 6a99527
Details
codecov/project/accountability 100% remains the same compared to 6a99527
Details
codecov/project/admin 100% remains the same compared to 6a99527
Details
codecov/project/api 100% remains the same compared to 6a99527
Details
codecov/project/assemblies 100% remains the same compared to 6a99527
Details
codecov/project/budgets 100% remains the same compared to 6a99527
Details
codecov/project/comments 100% remains the same compared to 6a99527
Details
codecov/project/core 100% remains the same compared to 6a99527
Details
codecov/project/meetings 100% remains the same compared to 6a99527
Details
codecov/project/pages 100% remains the same compared to 6a99527
Details
codecov/project/processes 100% remains the same compared to 6a99527
Details
codecov/project/proposals 100% remains the same compared to 6a99527
Details
codecov/project/surveys 100% remains the same compared to 6a99527
Details
codecov/project/system 100% remains the same compared to 6a99527
Details

@ghost ghost removed the in-review label Oct 18, 2017

@mrcasals mrcasals deleted the admin/cta-button-link branch Oct 18, 2017

@mrcasals mrcasals referenced this pull request Jan 26, 2018

Open

Banner in home #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.