New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert doc reference from "rake" to "rails" #2431

Merged
merged 1 commit into from Dec 31, 2017

Conversation

Projects
None yet
3 participants
@SeanPrashad
Contributor

SeanPrashad commented Dec 29, 2017

馃帺 What? Why?

This PR updates documentation to reference rails instead of rake commands for tasks inside the generated app.

馃搶 Related Issues

馃搵 Subtasks

  • N/A

馃摲 Screenshots (optional)

  • N/A

馃懟 GIF

  • N/A

@SeanPrashad SeanPrashad changed the title from Convert doc references from `rake` to `rails` to Convert doc references from "rake" to "rails" Dec 29, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Dec 29, 2017

Codecov Report

Merging #2431 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2431   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files        1294     1294           
  Lines       30172    30172           
=======================================
  Hits        29775    29775           
  Misses        397      397

codecov bot commented Dec 29, 2017

Codecov Report

Merging #2431 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2431   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files        1294     1294           
  Lines       30172    30172           
=======================================
  Hits        29775    29775           
  Misses        397      397
@deivid-rodriguez

This comment has been minimized.

Show comment
Hide comment
@deivid-rodriguez

deivid-rodriguez Dec 29, 2017

Collaborator

Hi @SeanPrashad, thanks so much for helping out with this!

We probably failed to explain the issue correctly. We need to update the documentation for tasks inside generated applications. The tasks run from the decidim root folder still need to be run via rake, since the decidim repo itself is not a Rails application and thus the rails command is not available.

That all means the only change we actually want to keep would be the one in decidim-dev/README.md, and that one should fix this issue. Could you update the PR? 馃槂

Collaborator

deivid-rodriguez commented Dec 29, 2017

Hi @SeanPrashad, thanks so much for helping out with this!

We probably failed to explain the issue correctly. We need to update the documentation for tasks inside generated applications. The tasks run from the decidim root folder still need to be run via rake, since the decidim repo itself is not a Rails application and thus the rails command is not available.

That all means the only change we actually want to keep would be the one in decidim-dev/README.md, and that one should fix this issue. Could you update the PR? 馃槂

@xabier

This comment has been minimized.

Show comment
Hide comment
@xabier

xabier Dec 29, 2017

Member

@SeanPrashad you are more than welcome to move to a more challenging PR next 馃槃

Member

xabier commented Dec 29, 2017

@SeanPrashad you are more than welcome to move to a more challenging PR next 馃槃

@SeanPrashad

This comment has been minimized.

Show comment
Hide comment
@SeanPrashad

SeanPrashad Dec 29, 2017

Contributor

@deivid-rodriguez PR has been updated! I reverted back the changes in everything but decidim-dev/README.md 馃榿

Contributor

SeanPrashad commented Dec 29, 2017

@deivid-rodriguez PR has been updated! I reverted back the changes in everything but decidim-dev/README.md 馃榿

@deivid-rodriguez

This comment has been minimized.

Show comment
Hide comment
@deivid-rodriguez

deivid-rodriguez Dec 30, 2017

Collaborator

@SeanPrashad Almost there but not quite yet! Changes in README.md need to be reverted since bundle exec rails s is correct there. Note that we cd into the application folder before that so those happen in the application folder (and bundle exec rake s does not exist anyways :))

Collaborator

deivid-rodriguez commented Dec 30, 2017

@SeanPrashad Almost there but not quite yet! Changes in README.md need to be reverted since bundle exec rails s is correct there. Note that we cd into the application folder before that so those happen in the application folder (and bundle exec rake s does not exist anyways :))

@SeanPrashad SeanPrashad changed the title from Convert doc references from "rake" to "rails" to Convert doc reference from "rake" to "rails" Dec 30, 2017

@SeanPrashad

This comment has been minimized.

Show comment
Hide comment
@SeanPrashad

SeanPrashad Dec 31, 2017

Contributor

@deivid-rodriguez I've updated the PR to fix the other lines that I modified which weren't supposed to be touched 馃榾 ! Please let me know if there is anything else I can do

Contributor

SeanPrashad commented Dec 31, 2017

@deivid-rodriguez I've updated the PR to fix the other lines that I modified which weren't supposed to be touched 馃榾 ! Please let me know if there is anything else I can do

@deivid-rodriguez deivid-rodriguez merged commit 9135a52 into decidim:master Dec 31, 2017

19 checks passed

ci/circleci: accountability Your tests passed on CircleCI!
Details
ci/circleci: admin Your tests passed on CircleCI!
Details
ci/circleci: api Your tests passed on CircleCI!
Details
ci/circleci: assemblies Your tests passed on CircleCI!
Details
ci/circleci: budgets Your tests passed on CircleCI!
Details
ci/circleci: build_test_app Your tests passed on CircleCI!
Details
ci/circleci: comments Your tests passed on CircleCI!
Details
ci/circleci: core Your tests passed on CircleCI!
Details
ci/circleci: main Your tests passed on CircleCI!
Details
ci/circleci: meetings Your tests passed on CircleCI!
Details
ci/circleci: pages Your tests passed on CircleCI!
Details
ci/circleci: processes Your tests passed on CircleCI!
Details
ci/circleci: proposals Your tests passed on CircleCI!
Details
ci/circleci: surveys Your tests passed on CircleCI!
Details
ci/circleci: system Your tests passed on CircleCI!
Details
ci/circleci: verifications Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codecov/patch Coverage not affected when comparing 80508ca...cdfffd0
Details
codecov/project 98.68% remains the same compared to 80508ca
Details
@deivid-rodriguez

This comment has been minimized.

Show comment
Hide comment
@deivid-rodriguez

deivid-rodriguez Dec 31, 2017

Collaborator

Nothing else, thanks!!

Collaborator

deivid-rodriguez commented Dec 31, 2017

Nothing else, thanks!!

@SeanPrashad SeanPrashad deleted the SeanPrashad:2386 branch Dec 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment