Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decidim design app #2766

Merged
merged 1 commit into from Feb 19, 2018

Conversation

@josepjaume
Copy link
Contributor

commented Feb 19, 2018

馃帺 What? Why?

This fixes decidim design's app deployment issues on heroku.

馃搶 Related Issues

None

馃搵 Subtasks

None

馃摲 Screenshots (optional)

None

@ghost ghost assigned josepjaume Feb 19, 2018
@ghost ghost added the in-progress label Feb 19, 2018
@josepjaume josepjaume force-pushed the fix_design_app branch from 30fc848 to aee46ec Feb 19, 2018
@codecov

This comment has been minimized.

Copy link

commented Feb 19, 2018

Codecov Report

Merging #2766 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2766   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files        1534     1534           
  Lines       36091    36091           
=======================================
  Hits        35679    35679           
  Misses        412      412
Copy link
Contributor

left a comment

I'm stumped by this issue, I'll definitely research this when I get some free time!

@josepjaume

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2018

It must have something to to with the way Heroku deals with containers because I can't reproduce it locally. Sorry to resort to this but really needed this up'n'running and couldn't find any other solution. The damage is contained to the dockerfile, though.

@josepjaume josepjaume merged commit 82be733 into master Feb 19, 2018
21 checks passed
21 checks passed
ci/circleci: accountability Your tests passed on CircleCI!
Details
ci/circleci: admin Your tests passed on CircleCI!
Details
ci/circleci: api Your tests passed on CircleCI!
Details
ci/circleci: assemblies Your tests passed on CircleCI!
Details
ci/circleci: budgets Your tests passed on CircleCI!
Details
ci/circleci: build_design_app Your tests passed on CircleCI!
Details
ci/circleci: build_test_app Your tests passed on CircleCI!
Details
ci/circleci: comments Your tests passed on CircleCI!
Details
ci/circleci: core Your tests passed on CircleCI!
Details
ci/circleci: debates Your tests passed on CircleCI!
Details
ci/circleci: main Your tests passed on CircleCI!
Details
ci/circleci: meetings Your tests passed on CircleCI!
Details
ci/circleci: pages Your tests passed on CircleCI!
Details
ci/circleci: processes Your tests passed on CircleCI!
Details
ci/circleci: proposals Your tests passed on CircleCI!
Details
ci/circleci: surveys Your tests passed on CircleCI!
Details
ci/circleci: system Your tests passed on CircleCI!
Details
ci/circleci: verifications Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codecov/patch Coverage not affected when comparing 4e0e4f1...aee46ec
Details
codecov/project 98.85% remains the same compared to 4e0e4f1
Details
@ghost ghost removed the in-progress label Feb 19, 2018
@josepjaume josepjaume deleted the fix_design_app branch Feb 19, 2018
@deivid-rodriguez

This comment has been minimized.

Copy link
Contributor

commented Feb 20, 2018

No problem @josepjaume, we need to make things work, and this workaround works! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.