Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce double quotes on JS #3092

Merged
merged 1 commit into from Mar 23, 2018

Conversation

@deivid-rodriguez
Copy link
Contributor

commented Mar 23, 2018

馃帺 What? Why?

Always unsure of which style to use since current files mix both, so fixing #2997. In JS, both quote type are 100% equivalent, right?

馃搶 Related Issues

馃搵 Subtasks

None.

馃摲 Screenshots (optional)

None.

@ghost ghost added the status: WIP label Mar 23, 2018
@mrcasals

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2018

There was a general consensus on using double quotes, so 馃憤 for me!

@josepjaume

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2018

You and your linters 馃う鈥嶁檪锔

@mrcasals

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2018

Go Linters Team!

@deivid-rodriguez

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2018

Hehehe, I can't help it...

{ term: term },
function(data) { response(data); }
);
},
renderItem: function (item, search) {
let sanitizedSearch = search.replace(/[-/\\^$*+?.()|[\]{}]/g, '\\$&');
let re = new RegExp(`(${sanitizedSearch.split(' ').join('|')})`, "gi");
let sanitizedSearch = search.replace(/[-/\\^$*+?.()|[\]{}]/g, "\\$&");

This comment has been minimized.

Copy link
@deivid-rodriguez

deivid-rodriguez Mar 23, 2018

Author Contributor

This thingies are equivalent right? I mean, escape character interpretation is not influenced by the type of quoting... or is it?

@codecov

This comment has been minimized.

Copy link

commented Mar 23, 2018

Codecov Report

Merging #3092 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #3092   +/-   ##
======================================
  Coverage    98.6%   98.6%           
======================================
  Files        1718    1718           
  Lines       41076   41076           
======================================
  Hits        40502   40502           
  Misses        574     574
@josepjaume josepjaume merged commit d5cbd34 into master Mar 23, 2018
21 checks passed
21 checks passed
ci/circleci: accountability Your tests passed on CircleCI!
Details
ci/circleci: admin Your tests passed on CircleCI!
Details
ci/circleci: api Your tests passed on CircleCI!
Details
ci/circleci: assemblies Your tests passed on CircleCI!
Details
ci/circleci: budgets Your tests passed on CircleCI!
Details
ci/circleci: build_design_app Your tests passed on CircleCI!
Details
ci/circleci: build_test_app Your tests passed on CircleCI!
Details
ci/circleci: comments Your tests passed on CircleCI!
Details
ci/circleci: core Your tests passed on CircleCI!
Details
ci/circleci: debates Your tests passed on CircleCI!
Details
ci/circleci: main Your tests passed on CircleCI!
Details
ci/circleci: meetings Your tests passed on CircleCI!
Details
ci/circleci: pages Your tests passed on CircleCI!
Details
ci/circleci: processes Your tests passed on CircleCI!
Details
ci/circleci: proposals Your tests passed on CircleCI!
Details
ci/circleci: surveys Your tests passed on CircleCI!
Details
ci/circleci: system Your tests passed on CircleCI!
Details
ci/circleci: verifications Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codecov/patch Coverage not affected when comparing 4a24cc2...8c1a6e0
Details
codecov/project 98.6% remains the same compared to 4a24cc2
Details
@josepjaume josepjaume deleted the js_quotes branch Mar 23, 2018
@ghost ghost removed the status: WIP label Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.