Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete field #3301

Merged
merged 4 commits into from May 9, 2018

Conversation

@rbngzlv
Copy link
Member

commented Apr 26, 2018

馃帺 What? Why?

I need an autocomplete field for assembly members feature, so I worked in a reusable component.

馃搶 Related Issues

馃搵 Subtasks

  • Add CHANGELOG entry
@ghost ghost assigned rbngzlv Apr 26, 2018
@ghost ghost added the status: WIP label Apr 26, 2018
@rbngzlv rbngzlv force-pushed the feature/autocomplete_field branch from 1655f71 to 74b0163 Apr 26, 2018
@rbngzlv rbngzlv added this to the Release v.0.11.0 milestone Apr 26, 2018
@rbngzlv rbngzlv force-pushed the feature/autocomplete_field branch from 5701fbc to 8269709 Apr 26, 2018
@deivid-rodriguez

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2018

I'm personally really impressed by your work, 鉂わ笍. Specially thankful for extracting this to a separate PR and documenting the stuff so we can more easily all learn the tools and techniques being used here.

I recall we're using autocompletion through a jquery plugin or something like that in other places? Would be great to unify all that to use this component in the future if it makes sense!

@rbngzlv rbngzlv force-pushed the feature/autocomplete_field branch from 8269709 to 0ff8929 Apr 26, 2018
@rbngzlv

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2018

@deivid-rodriguez thanks for your comments, they are very welcome. I appreciate your comments and that you take time to take a look at this. 馃槂

@rbngzlv

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2018

Running npm run build:prod (that generates the bundle for admin and comments) does not generate the same bundle for comments that running COMPONENT=comments npm run build:prod. The same for COMPONENT=comments npm run build:prod vs npm run build:prod.

Anyone knows if this expected with webpack? If yes, we need to take a decision to use one or another command.

/cc @decidim/lot-core

@rbngzlv rbngzlv added in-review and removed status: WIP labels Apr 27, 2018
@rbngzlv

This comment has been minimized.

Copy link
Member Author

commented Apr 27, 2018

@decidim/lot-core apart from the problem with the generation of the bundle, the rest can be reviewed.

@rbngzlv rbngzlv referenced this pull request Apr 27, 2018
1 of 1 task complete
@isaacmg410

This comment has been minimized.

Copy link
Contributor

commented May 4, 2018

@decidim/lot-core we have two PR that depends on this reusable autocomplete field, can you take a look to the approach used in this PR and check the @rbngzlv comments so he can finish it, please?

@mrcasals

This comment has been minimized.

Copy link
Contributor

commented May 4, 2018

@rbngzlv sorry, I missed your comments.

I'm not sure how this works, I use bundle exec rake webpack from the root folder whenever I need to generate the bundles when importing locales...

@oriolgual

This comment has been minimized.

Copy link
Member

commented May 4, 2018

@rbngzlv I'm not sure either if it's an expected behaviour (/cc @josepjaume), but since rake webpack uses npm run build:prod I guess we should stick to that.

@deivid-rodriguez

This comment has been minimized.

Copy link
Contributor

commented May 6, 2018

@rbngzlv I think this might be a bug/inconsistency in webpack. Did you take this solution from webpack/webpack#3455 (comment), maybe it's worth asking the person who posted it.

However, we don't usually regenerate these things a lot for now, so maybe it's better to remove the process.env.COMPONENT dance and regenerate everything, everytime with our current npm run build:prod.

@tramuntanal

This comment has been minimized.

Copy link
Contributor

commented May 7, 2018

@rbngzlv @isaacmg410 this PR is expected to be merged this week to enter v0.12. Do you expect to have it finished soon?

@rbngzlv rbngzlv force-pushed the feature/autocomplete_field branch from 0ff8929 to 5bf4284 May 8, 2018
@ghost ghost added the status: WIP label May 8, 2018
@rbngzlv rbngzlv force-pushed the feature/autocomplete_field branch from 5bf4284 to e208d81 May 8, 2018
@rbngzlv

This comment has been minimized.

Copy link
Member Author

commented May 9, 2018

Removed the component flag to stick with our current npm run build:prod.

@decidim/lot-core can you review the PR?

@rbngzlv rbngzlv added general: admin and removed status: WIP labels May 9, 2018
@oriolgual oriolgual merged commit 0daf8b8 into master May 9, 2018
27 checks passed
27 checks passed
ci/circleci: accountability Your tests passed on CircleCI!
Details
ci/circleci: admin Your tests passed on CircleCI!
Details
ci/circleci: api Your tests passed on CircleCI!
Details
ci/circleci: assemblies Your tests passed on CircleCI!
Details
ci/circleci: blogs Your tests passed on CircleCI!
Details
ci/circleci: budgets Your tests passed on CircleCI!
Details
ci/circleci: build_design_app Your tests passed on CircleCI!
Details
ci/circleci: build_test_app Your tests passed on CircleCI!
Details
ci/circleci: comments Your tests passed on CircleCI!
Details
ci/circleci: consultations Your tests passed on CircleCI!
Details
ci/circleci: core Your tests passed on CircleCI!
Details
ci/circleci: debates Your tests passed on CircleCI!
Details
ci/circleci: generators Your tests passed on CircleCI!
Details
ci/circleci: initiatives Your tests passed on CircleCI!
Details
ci/circleci: main Your tests passed on CircleCI!
Details
ci/circleci: meetings Your tests passed on CircleCI!
Details
ci/circleci: pages Your tests passed on CircleCI!
Details
ci/circleci: participatory_processes Your tests passed on CircleCI!
Details
ci/circleci: proposals Your tests passed on CircleCI!
Details
ci/circleci: sortitions Your tests passed on CircleCI!
Details
ci/circleci: surveys Your tests passed on CircleCI!
Details
ci/circleci: system Your tests passed on CircleCI!
Details
ci/circleci: upload-coverage Your tests passed on CircleCI!
Details
ci/circleci: verifications Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (80% threshold)
Details
codeclimate/total-coverage 98% (0.0% change)
Details
@oriolgual oriolgual deleted the feature/autocomplete_field branch May 9, 2018
isaacmg410 added a commit to CodiTramuntana/decidim that referenced this pull request May 25, 2018
* Add autocomplete field to admin

* Apply linterns suggestions and fix things

* Remove COMPONENT flags for webpack

* Add change log entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can鈥檛 perform that action at this time.