An assembly member can be an existing user #3302
Conversation
ghost
assigned
| attribute :position_other, String | ||
| attribute :user_id, Integer | ||
| attribute :existing_user, Boolean, default: false | ||
| attribute :user_id, Integer |
|
|
||
| query = current_organization.users&.order(name: :asc) | ||
| term = params[:term] | ||
| if term&.start_with?("@") |
There was a problem hiding this comment.
I've seen this code in other PRs, should we extract this to a class or something?
There was a problem hiding this comment.
Yo've seen it in the same module? If not, we need to extract it to the core module so we don't add a dependency to the admin, right? We can extract it to a query class?
There was a problem hiding this comment.
@oriolgual, you refer to this other PR that we are "arguing" there. #3136 (comment)
We can look for a solution for both systems. What do you recommend?
Create a OrganizersController or UsersController but should be done in Decidim::Core no?
There was a problem hiding this comment.
Yes, should be done at core, no problem. I'd go with a OrganizersController
There was a problem hiding this comment.
good! But in this case, will be UsersController ?
rbngzlv
force-pushed
the
feature/assembly_members_belongs_to_user
branch
from
955f457 to
8750a8b
Compare
rbngzlv
changed the base branch from
feature/assembly_members
to
feature/move_organizer_picker_to_autocomplete_field
rbngzlv
force-pushed
the
feature/assembly_members_belongs_to_user
branch
from
8750a8b to
714dd92
Compare
rbngzlv
force-pushed
the
feature/move_organizer_picker_to_autocomplete_field
branch
from
30c0900 to
c228ab0
Compare
rbngzlv
changed the base branch from
feature/move_organizer_picker_to_autocomplete_field
to
master
rbngzlv
force-pushed
the
feature/assembly_members_belongs_to_user
branch
from
714dd92 to
31d1f22
Compare
|
@decidim/lot-core review it please, rebased on master after merging #3387. |
🎩 What? Why?
This PR sits on #3008 and #3301 and add the possibility to link an assembly member to an existing user in the platform.
I'm pointing this PR to the
feature/assembly_membersbranch so you can review it faster, once merged, I'll point this to the master branch.📌 Related Issues
📋 Subtasks
CHANGELOGentry