Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn that attachment is lost when form is errored #3553

Merged
merged 1 commit into from May 31, 2018

Conversation

mrcasals
Copy link
Contributor

馃帺 What? Why?

When the proposal form has an attachment but fails due to an error in another field, the attachment is lost and the user is not aware of it. This PR adds a message to the form to warn the user of the issue.

馃搶 Related Issues

馃搵 Subtasks

  • Add CHANGELOG entry

馃摲 Screenshots (optional)

Description

@mrcasals mrcasals force-pushed the proposals/warn-missing-attachment branch from 7fbbd45 to 1224450 Compare May 31, 2018 11:03
@mrcasals mrcasals merged commit 10176b5 into master May 31, 2018
@mrcasals mrcasals deleted the proposals/warn-missing-attachment branch May 31, 2018 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants