Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consistent circle ci env #3732

Merged
merged 4 commits into from Jul 3, 2018

Conversation

@deivid-rodriguez
Copy link
Contributor

commented Jun 27, 2018

馃帺 What? Why?

These are some other changes that I extracted from #3684. The idea is to make local docker & circleCI enviroments as similar as possible so it's easier to troubleshoot CI issues. I added an extra fixup to the package-lock.json, because npm install hang on the first run. I suspect there's some multiplatform issues hitting npm again. Let's see how it goes.

馃搶 Related Issues

馃搵 Subtasks

None.

馃摲 Screenshots (optional)

None.

@ghost ghost added the status: WIP label Jun 27, 2018
@mrcasals mrcasals added in-review and removed status: WIP labels Jun 28, 2018
This was a workaround for a bundler bug that should no longer be
happening.
To more exactly simulate CircleCI environment.
@deivid-rodriguez deivid-rodriguez dismissed stale reviews from josepjaume and mrcasals via 8dadf9c Jun 28, 2018
@deivid-rodriguez deivid-rodriguez force-pushed the more_consistent_circle_ci_env branch from aa8ae9c to 8dadf9c Jun 28, 2018
@ghost ghost added the status: WIP label Jun 28, 2018
@deivid-rodriguez

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2018

npm install is hanging again, and it seems to be affecting random unrelated PRs also. I tried removing npm caching but I'm not very hopeful, I think this is somehow due to the node update in the base image and we might need to revert it...

@deivid-rodriguez

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2018

Removing npm caching seems to have done the trick and doesn't seem to affect npm ci substantially. But I'm not sure if this is intermittent and will come back. 馃し鈥嶁檪

@deivid-rodriguez

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2018

@oriolgual I'm not getting feedback here from either @mrcasals or @josepjaume, so I suspect they might be on holidays. Could you approve this or give feedback in order to get master green again? Thanks 鉂わ笍

@mrcasals

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2018

@deivid-rodriguez hi, sorry for the delay on this! Merging the PR! 馃槃

@mrcasals mrcasals merged commit 93cc67a into master Jul 3, 2018
26 checks passed
26 checks passed
WIP ready for review
Details
ci/circleci: accountability Your tests passed on CircleCI!
Details
ci/circleci: admin Your tests passed on CircleCI!
Details
ci/circleci: api Your tests passed on CircleCI!
Details
ci/circleci: assemblies Your tests passed on CircleCI!
Details
ci/circleci: blogs Your tests passed on CircleCI!
Details
ci/circleci: budgets Your tests passed on CircleCI!
Details
ci/circleci: build_design_app Your tests passed on CircleCI!
Details
ci/circleci: build_test_app Your tests passed on CircleCI!
Details
ci/circleci: comments Your tests passed on CircleCI!
Details
ci/circleci: consultations Your tests passed on CircleCI!
Details
ci/circleci: core Your tests passed on CircleCI!
Details
ci/circleci: debates Your tests passed on CircleCI!
Details
ci/circleci: generators Your tests passed on CircleCI!
Details
ci/circleci: initiatives Your tests passed on CircleCI!
Details
ci/circleci: main Your tests passed on CircleCI!
Details
ci/circleci: meetings Your tests passed on CircleCI!
Details
ci/circleci: pages Your tests passed on CircleCI!
Details
ci/circleci: participatory_processes Your tests passed on CircleCI!
Details
ci/circleci: proposals Your tests passed on CircleCI!
Details
ci/circleci: sortitions Your tests passed on CircleCI!
Details
ci/circleci: surveys Your tests passed on CircleCI!
Details
ci/circleci: system Your tests passed on CircleCI!
Details
ci/circleci: upload-coverage Your tests passed on CircleCI!
Details
ci/circleci: verifications Your tests passed on CircleCI!
Details
codeclimate All good!
Details
@mrcasals mrcasals deleted the more_consistent_circle_ci_env branch Jul 3, 2018
@mrcasals

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2018

@deivid-rodriguez after merging this PR we're getting this error on master:

#!/bin/bash -eo pipefail
mkdir ~/rspec && cd decidim-$CIRCLE_JOB && bundle exec rake
Could not find autoprefixer-rails-8.6.4 in any of the sources
Run `bundle install` to install missing gems.
Exited with code 7

https://circleci.com/gh/decidim/decidim/122898

@mrcasals

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2018

Mh, the decidim-generators Gemfile.lock file from master differs from the one in the main folder, but the tests are not catching the error:

autoprefixer-rails (8.6.4)

autoprefixer-rails (8.6.2)

Any idea why this might be happening?

@deivid-rodriguez

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2018

Arggg this is tough. Lockfile specs are not supposed to catch that, they just check that each Gemfile is in sync with its lockfile. But we could maybe add it.

@mrcasals

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2018

Oh, I see. Maybe we should?

Or maybe we should bundle install inside the folder before running the tests in decidim-generators?

That'd be simpler, I think, and avoids us coupling the Gemfile.lock files.

@deivid-rodriguez

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2018

Yeah, we can do that. 馃憤

@mrcasals

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2018

@deivid-rodriguez I'll take care of it on #3756 then 馃槃

@mrcasals mrcasals referenced this pull request Jul 3, 2018
mrcasals added a commit that referenced this pull request Jul 5, 2018
* Remove unnecessary env on Circle CI

This was a workaround for a bundler bug that should no longer be
happening.

* Run tests through bundler

* Pass SIMPLECOV env to docker specs

To more exactly simulate CircleCI environment.

* Remove npm caching
josepjaume added a commit that referenced this pull request Jul 10, 2018
* More consistent circle ci env (#3732)

* Remove unnecessary env on Circle CI

This was a workaround for a bundler bug that should no longer be
happening.

* Run tests through bundler

* Pass SIMPLECOV env to docker specs

To more exactly simulate CircleCI environment.

* Remove npm caching

* Block sassc dependency version (#3775)

Fix dependencies

* Update deps

* Revert "Flexibilize internal dependencies"

This reverts commit 434e93c.

* Update deps

* Fix deps

* Run all generators tests to see what fails

* Test generators against the very same branch

* Update more deps

* Fix generators issue (#3684)

* Add change log entry

* Move `with_original_env` out of generators

* Remove unexistent file from rubocop exclusions

* Let binstubs respect current folder

* Fix generated apps not including optional plugins

* Restore RUBYLIB after loading the right version

* Revert "Run all generators tests to see what fails"

This reverts commit 4e6de3d.

* Revert "Test generators against the very same branch"

This reverts commit 4430c3c.

* Update deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.