Hashtags Feature applied to Proposals by isaacmg410 · Pull Request #3959 · decidim/decidim

isaacmg410 · 2018-08-03T12:32:49Z

🎩 What? Why?

This functionality will consist of the development of a new feature Hashtags provide a flexible way to search and filter content.

📌 Related Issues

Related to Hashtags #2458

📋 Subtasks

Add CHANGELOG entry
Add hashtags features to proposals
Add documentation regarding the feature
Add tests

📷 Screenshots (optional)

isaacmg410 · 2018-08-03T12:34:06Z

@decidim/lot-core I would appreciate a pre-review of this PR.
I will try to make more smaller PRs for a better 😄

mrcasals · 2018-08-06T07:49:30Z

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+class CreateDecidimHashtagggings < ActiveRecord::Migration[5.2]


Looks like there's an extra g here

mrcasals · 2018-08-06T07:50:29Z

+      description "hashtags list"
+
+      interfaces [
+        -> { Decidim::Core::HashtagInterface }


Will this interface be used by other types? If it won't, then I suggest putting the fields definition directly to the type to reduce complexity.

mrcasals · 2018-08-06T07:51:19Z

+      t.references :decidim_hashtag, index: true
+      t.references :decidim_hashtaggable, polymorphic: true, index: { name: "idx_hashtaggins_on_hashtaggable_type_and_hashtaggable_id" }
+    end
+    add_index :decidim_hashtaggings, %w(decidim_hashtaggable_id decidim_hashtaggable_type),


Isn't this a duplicate from the index in line 7?

mrcasals · 2018-08-06T07:51:51Z

+      name "HashtagInterface"
+      description "A hashtag"
+
+      field :name, !types.String, "The hashtag's name"


I suggest moving this to the HashtagType and deleting this file.

mrcasals · 2018-08-06T07:52:28Z

+      # hashtag with a global id.
+      #
+      # @return [String] the content with the hashtags replaced by a global id
+


Remove extra white line

mrcasals · 2018-08-06T08:06:12Z

+
+    context "when hashtagging a non created hashtag" do
+      let(:hashtag3) { create(:hashtag, organization: organization) }
+      let(:content) { "This text hashtagiing a non created hashtag: ##{hashtag3.name}" }


hashtag3 does exist in the DB, so this test is wrong.

mrcasals · 2018-08-06T08:07:06Z

-            title: @form.title,
-            description: @form.description,
+            # title: @form.title,
+            title: parser.parse(@form.title),


Can titles have hashtags? Won't this be weird when rendering?

a long time ago, @xabier said that fields were title and body...
Maybe @decidim/product can clarify

mrcasals · 2018-08-06T08:08:26Z

+          # parsed_title = Decidim::ContentProcessor.parse(form.title, current_organization: current_organization).rewrite
+          # parsed_body = Decidim::ContentProcessor.parse(form.body, current_organization: current_organization).rewrite
+
+          parsed_title = Decidim::ContentProcessor.parse_with_processor(:hashtag, form.title, current_organization: current_organization).rewrite


Move these 2 lines inside the attributes method and you won't need to pass those as params

mrcasals · 2018-08-06T08:09:16Z

+        renderer.render.html_safe
+      end
+
+      # This methods return the plain title


mrcasals · 2018-08-06T08:09:53Z

    <%= proposal.id %><br />
  </td>
  <td>
-    <%= proposal.title %><br />


Missing <br />? Don't know if it's intended though.

oriolgual · 2018-08-06T08:09:48Z

+    }).fail(function() {
+      cb([])
+    }).always(() => {
+      // This function runs Tribute every single time you type somthing


s/somthing/something 🤓

oriolgual · 2018-08-06T08:10:26Z

+        if ($(this.current.element).hasClass("editor-container")) {
+          let quill = this.current.element.__quill;
+          quill.insertText(cursor - 1, `#${item.original.name} `, Quill.sources.API);
+          // cursor position + nickname length + "@" sign + space


Nickname or hashtag?

oriolgual · 2018-08-06T08:11:22Z

+    }
+  });
+
+  function remoteSearch(text, cb) {


Duplicated function?

oriolgual · 2018-08-06T08:12:19Z

+    end
+
+    def hashtags
+      Decidim::Hashtag.where(organization: @organization).where("name like ?", "#{@term}%")


Why use like?

to collect hashtags with the names thah begin with 'bla' for example

Then don't we need something like "name like ?%"?

Oh, I didn't see the % at the end, sorry.

Don't worry 😄

oriolgual · 2018-08-06T08:13:38Z

+      name "HashtagInterface"
+      description "A hashtag"
+
+      field :name, !types.String, "The hashtag's name"


Since this interface won't be used anywhere else, you can drop it and move the field to the type

oriolgual · 2018-08-06T08:14:58Z

+    #
+    # @see BaseRenderer Examples of how to use a content renderer
+    class HashtagRenderer < BaseRenderer
+      # Matches a global id representing a Decidim::User


s/User/Hashtag

oriolgual · 2018-08-06T08:19:01Z

+    HASHTAG_REGEX = /(^|\s)#([a-zA-Z0-9]\w*)/i
+
+    def hashtaggables
+      decidim_hashtaggings.includes(:decidim_hashtaggable).collect(&:decidim_hashtaggable)


Should we memoize this?

oriolgual · 2018-08-06T08:19:51Z

+      decidim_hashtaggings.includes(:decidim_hashtaggable).collect(&:decidim_hashtaggable)
+    end
+
+    def hashtagged_types


These methods aren't used

oriolgual · 2018-08-06T08:20:57Z

        attr_reader :form, :proposal, :attachment

        def create_proposal
+          # parsed_title = Decidim::ContentProcessor.parse(form.title, current_organization: current_organization).rewrite


Remove this?

oriolgual · 2018-08-06T08:22:43Z

+          # parsed_title = Decidim::ContentProcessor.parse(form.title, current_organization: current_organization).rewrite
+          # parsed_body = Decidim::ContentProcessor.parse(form.body, current_organization: current_organization).rewrite
+
+          parsed_title = Decidim::ContentProcessor.parse_with_processor(:hashtag, form.title, current_organization: current_organization).rewrite


Isn't a bit weird to allow hashtags at titles?

@decidim/product clarify this please.

@isaacmg410 @oriolgual I have checked the conversation in the original issue and we agreed to ignore the hashtags in the title: #2458 (comment)

so that is what we are doing.
Show the hashtag on title ignoring the link 😄

oriolgual · 2018-08-27T09:59:20Z

      include Decidim::Searchable
      include Decidim::Traceable
      include Decidim::Loggable
+      include Decidim::Hashtaggable


Shouldn't this be in another PR?

You are right!

…hashtags

isaacmg410 · 2018-08-29T09:47:45Z

@oriolgual requested changes applied, ready to review and merge

Isaac Massot added 3 commits August 2, 2018 11:32

initial commit working on hashtags system

5a65ea4

applying hashtags on proposals

293b5cd

rebase master and solve conflicts

df6c420

ghost assigned isaacmg410 Aug 3, 2018

ghost added the status: WIP label Aug 3, 2018

mrcasals reviewed Aug 6, 2018

View reviewed changes

oriolgual suggested changes Aug 6, 2018

View reviewed changes

Isaac Massot added 6 commits August 20, 2018 17:09

Merge branch 'master' into 2458_hashtags

b9502e6

applied requested changes

7baec08

Merge branch 'master' into 2458_hashtags

ef1269a

fix specs

085791d

Merge branch 'master' into 2458_hashtags

d264413

change eslint in package json

0c8e8f1

isaacmg410 changed the title ~~[WIP] Hashtags Feature applied to Proposals~~ Hashtags Feature applied to Proposals Aug 27, 2018

Isaac Massot added 5 commits August 27, 2018 10:29

fix input_hashtags.js

7774e2a

change versions package.json

e042d24

upgrade with master and fix conflicts

effc8e6

fix rubocop offenses

8d31960

Don't leave trailing whitespace

ca9e245

oriolgual suggested changes Aug 27, 2018

View reviewed changes

Isaac Massot added 6 commits August 27, 2018 12:02

Merge branch 'master' into 2458_hashtags

1758963

remove hashtaggable on meeting

e5757e1

add changelog lines

60fbf14

Merge branch 'master' into 2458_hashtags

0bb5cd6

Merge branch '2458_hashtags' of github.com:decidim/decidim into 2458_…

32d37d8

…hashtags

Merge branch 'master' into 2458_hashtags

10a63d8

isaacmg410 added in-review and removed status: WIP labels Aug 28, 2018

Merge branch 'master' into 2458_hashtags

b80a7d0

ghost assigned oriolgual Aug 29, 2018

ghost added the status: WIP label Aug 29, 2018

oriolgual approved these changes Aug 29, 2018

View reviewed changes

mrcasals removed the status: WIP label Aug 30, 2018

mrcasals merged commit 006a084 into master Aug 30, 2018

mrcasals deleted the 2458_hashtags branch August 30, 2018 08:43

This was referenced Sep 5, 2018

Apply hashtags to meetings #4080

Merged

Fix hashtags on title when showing proposals related #4081

Merged

isaacmg410 mentioned this pull request Sep 13, 2018

[backport] Fix hashtags on title when showing proposals related #4107

Merged

3 tasks

		@@ -0,0 +1,16 @@
		# frozen_string_literal: true

		class CreateDecidimHashtagggings < ActiveRecord::Migration[5.2]

Uh oh!

Uh oh!

Conversation

isaacmg410 commented Aug 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎩 What? Why?

📌 Related Issues

📋 Subtasks

📷 Screenshots (optional)

Uh oh!

isaacmg410 commented Aug 3, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

isaacmg410 commented Aug 29, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

isaacmg410 commented Aug 3, 2018 •

edited

Loading