Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

New badges #4033

Merged
merged 4 commits into from Aug 28, 2018
Merged

New badges #4033

merged 4 commits into from Aug 28, 2018

Conversation

@josepjaume
Copy link
Contributor

@josepjaume josepjaume commented Aug 27, 2018

馃帺 What? Why?

Adds new badges for the gamification feature:

  • Accepted proposals
  • Invitations
  • Published initiatives
  • Proposal supports

馃搶 Related Issues

馃搵 Subtasks

  • Add CHANGELOG entry
  • Add tests

馃摲 Screenshots (optional)

image

@ghost ghost assigned josepjaume Aug 27, 2018
@ghost ghost added the status: WIP label Aug 27, 2018
@josepjaume josepjaume force-pushed the add_badges branch 2 times, most recently from ce21b18 to 7a35372 Aug 27, 2018
@josepjaume josepjaume changed the title Add badges New badges Aug 27, 2018
@@ -26,6 +26,9 @@ def call
return broadcast(:invalid) unless vote.valid?

vote.save!

Decidim::Gamification.increment_score(@current_user, :proposal_votes) if @proposal.votes.where(author: @current_user).count == 1
Copy link
Member

@oriolgual oriolgual Aug 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need to check this?

Loading

@ghost ghost added the status: WIP label Aug 28, 2018
@josepjaume josepjaume merged commit f0d599c into master Aug 28, 2018
28 checks passed
Loading
@josepjaume josepjaume deleted the add_badges branch Aug 28, 2018
@josepjaume josepjaume mentioned this pull request Aug 28, 2018
@josepjaume josepjaume mentioned this pull request Oct 22, 2018
@josepjaume josepjaume added this to the CDP3 milestone Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants