Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/4770 option to reset participatory text file #4814

Merged
merged 18 commits into from Feb 14, 2019

Conversation

Projects
None yet
3 participants
@tramuntanal
Copy link
Contributor

commented Feb 2, 2019

馃帺 What? Why?

Added a button to reset all participatory text drafts.

馃搶 Related Issues

馃搵 Subtasks

  • Add CHANGELOG entry
  • [-] Add documentation regarding the feature
  • [-] Add/modify seeds
  • Add tests
  • Task

馃摲 Screenshots (optional)

ezgif com-video-to-gif

@ghost ghost assigned tramuntanal Feb 2, 2019

@ghost ghost added the status: WIP label Feb 2, 2019

tramuntanal added some commits Feb 2, 2019

@tramuntanal tramuntanal added in-review and removed status: WIP labels Feb 2, 2019

@tramuntanal tramuntanal requested a review from isaacmg410 Feb 2, 2019

@isaacmg410
Copy link
Contributor

left a comment

Just some minor changes 馃槃

@ghost ghost added the status: WIP label Feb 4, 2019

tramuntanal added some commits Feb 4, 2019

Merge branch 'feature/4770-option_to_reset_participatory_text_file' o鈥
鈥 ssh://github.com/decidim/decidim into feature/4770-option_to_reset_participatory_text_file
@tramuntanal

This comment has been minimized.

Copy link
Contributor Author

commented Feb 4, 2019

@isaacmg410 changes applied.

@tramuntanal tramuntanal removed the status: WIP label Feb 4, 2019

@ghost ghost added the status: WIP label Feb 4, 2019

@tramuntanal tramuntanal removed the status: WIP label Feb 5, 2019

@tramuntanal

This comment has been minimized.

Copy link
Contributor Author

commented Feb 11, 2019

Hi @decidim/lot-core anybody here?

@ghost ghost added the status: WIP label Feb 13, 2019

@ghost ghost assigned oriolgual Feb 14, 2019

@tramuntanal

This comment has been minimized.

Copy link
Contributor Author

commented Feb 14, 2019

Hi @oriolgual
I've seen your refactor and it worked! Can you please explain the difference between the EngineRouter and the ResourceLocator? when should we use one or the other?

@oriolgual

This comment has been minimized.

Copy link
Member

commented Feb 14, 2019

Hi @oriolgual
I've seen your refactor and it worked! Can you please explain the difference between the EngineRouter and the ResourceLocator? when should we use one or the other?

We should always use the ResourceLocator generally. I had to fallback to the EngineRouter since participatory texts aren't resources and I couldn't use the resource locator!

@oriolgual oriolgual merged commit 874ccac into master Feb 14, 2019

30 checks passed

WIP Ready for review
Details
ci/circleci: accountability Your tests passed on CircleCI!
Details
ci/circleci: admin Your tests passed on CircleCI!
Details
ci/circleci: api Your tests passed on CircleCI!
Details
ci/circleci: assemblies Your tests passed on CircleCI!
Details
ci/circleci: blogs Your tests passed on CircleCI!
Details
ci/circleci: budgets Your tests passed on CircleCI!
Details
ci/circleci: build_design_app Your tests passed on CircleCI!
Details
ci/circleci: build_test_app Your tests passed on CircleCI!
Details
ci/circleci: comments Your tests passed on CircleCI!
Details
ci/circleci: conferences Your tests passed on CircleCI!
Details
ci/circleci: consultations Your tests passed on CircleCI!
Details
ci/circleci: core Your tests passed on CircleCI!
Details
ci/circleci: debates Your tests passed on CircleCI!
Details
ci/circleci: forms Your tests passed on CircleCI!
Details
ci/circleci: generators Your tests passed on CircleCI!
Details
ci/circleci: initiatives Your tests passed on CircleCI!
Details
ci/circleci: main Your tests passed on CircleCI!
Details
ci/circleci: meetings Your tests passed on CircleCI!
Details
ci/circleci: pages Your tests passed on CircleCI!
Details
ci/circleci: participatory_processes Your tests passed on CircleCI!
Details
ci/circleci: proposals Your tests passed on CircleCI!
Details
ci/circleci: sortitions Your tests passed on CircleCI!
Details
ci/circleci: surveys Your tests passed on CircleCI!
Details
ci/circleci: system Your tests passed on CircleCI!
Details
ci/circleci: upload-coverage Your tests passed on CircleCI!
Details
ci/circleci: verifications Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 98% (80% threshold)
Details
codeclimate/total-coverage 98% (0.0% change)
Details

@ghost ghost removed the status: WIP label Feb 14, 2019

@oriolgual oriolgual deleted the feature/4770-option_to_reset_participatory_text_file branch Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.