Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic fields elements for IE11 #5052

Merged
merged 4 commits into from Apr 5, 2019

Conversation

@ahukkanen
Copy link
Contributor

commented Apr 4, 2019

馃帺 What? Why?

This fixes the dynamic field elements for IE11 as explained in #5035.

This is an unfortunately complex fix for IE11 but it is the only way to make it compatible with that browser. The biggest issue with this is not actually the admin panel where we initially noticed issues with this but another component we built for the participation interface using the same component. Therefore, this component should consider both cases to support IE11 as well.

This should also maintain backwards compatibility in case someone is using the <template> tags with the dynamic fields component.

馃搶 Related Issues

馃搵 Subtasks

  • Add CHANGELOG entry
  • Fix tests
ahukkanen added 2 commits Apr 4, 2019
Because IE11 does not support the `<template>` tag very well,
add functionality to the dynamic fields component to match also
`<script type="text/template">` tags as an alternative.

The views need to use this type of templates in order for them to
work properly on IE11. Also, this types of templates cannot have
child templates meaning that the wrapper element needs to map the
child template with the `data-template` attribute.
With the updated dynamic fields component, it is now possible to
mark the dynamic fields markup with
`<script type="text/template">`. This makes them compatible with
IE11.

Also note that this types of templates cannot have any child
templates which is why the child templates have been moved outside
of the parent template and mapped with the `data-template`
attribute on the dynamic fields wrapper element.
Copy link
Contributor

left a comment

Looks good to me!

@mrcasals mrcasals merged commit a524dd3 into decidim:master Apr 5, 2019
29 checks passed
29 checks passed
ci/circleci: accountability Your tests passed on CircleCI!
Details
ci/circleci: admin Your tests passed on CircleCI!
Details
ci/circleci: api Your tests passed on CircleCI!
Details
ci/circleci: assemblies Your tests passed on CircleCI!
Details
ci/circleci: blogs Your tests passed on CircleCI!
Details
ci/circleci: budgets Your tests passed on CircleCI!
Details
ci/circleci: build_design_app Your tests passed on CircleCI!
Details
ci/circleci: build_test_app Your tests passed on CircleCI!
Details
ci/circleci: comments Your tests passed on CircleCI!
Details
ci/circleci: conferences Your tests passed on CircleCI!
Details
ci/circleci: consultations Your tests passed on CircleCI!
Details
ci/circleci: core Your tests passed on CircleCI!
Details
ci/circleci: debates Your tests passed on CircleCI!
Details
ci/circleci: forms Your tests passed on CircleCI!
Details
ci/circleci: generators Your tests passed on CircleCI!
Details
ci/circleci: initiatives Your tests passed on CircleCI!
Details
ci/circleci: main Your tests passed on CircleCI!
Details
ci/circleci: meetings Your tests passed on CircleCI!
Details
ci/circleci: pages Your tests passed on CircleCI!
Details
ci/circleci: participatory_processes Your tests passed on CircleCI!
Details
ci/circleci: proposals Your tests passed on CircleCI!
Details
ci/circleci: sortitions Your tests passed on CircleCI!
Details
ci/circleci: surveys Your tests passed on CircleCI!
Details
ci/circleci: system Your tests passed on CircleCI!
Details
ci/circleci: upload-coverage Your tests passed on CircleCI!
Details
ci/circleci: verifications Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (80% threshold)
Details
codeclimate/total-coverage 98% (0.0% change)
Details
@oriolgual oriolgual removed the status: WIP label Apr 5, 2019
@mrcasals

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

Thanks for those PRs @ahukkanen! 馃槃

@ahukkanen ahukkanen deleted the mainio:fix/5035 branch Apr 5, 2019
@isaacmg410

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

@ahukkanen This PR has added another problem.
We reported in metadecidim this morning https://meta.decidim.org/processes/bug-report/f/210/proposals/14698
Do you have time to fix it?

Thanks in advance 馃槃

@ahukkanen ahukkanen referenced this pull request Jul 20, 2019
2 of 2 tasks complete
@ahukkanen

This comment has been minimized.

Copy link
Contributor Author

commented Jul 20, 2019

@isaacmg410 See #5275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.