Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #5206

Merged
merged 10 commits into from Jun 22, 2019

Conversation

@oriolgual
Copy link
Member

commented Jun 17, 2019

馃帺 What? Why?

It's been a while since we updated dependencies.

@oriolgual oriolgual requested a review from josepjaume Jun 17, 2019
@oriolgual oriolgual requested a review from decidim/lot-core as a code owner Jun 17, 2019
@oriolgual oriolgual force-pushed the update_dependencies branch 3 times, most recently from 43dac4f to 8d22277 Jun 18, 2019
@oriolgual oriolgual force-pushed the update_dependencies branch 3 times, most recently from fd46d53 to 67c71ea Jun 21, 2019
oriolgual added 9 commits Jun 17, 2019
After debugging this for too many hours, I've concluded that if a scope
has an "s" in its name, for some reason I fail to understand, it is
escaped and represented as &#115 (which is an "s" for html entitites).
This seems to happen at browser level and I can't reproduce it otuside
the test environment.
@oriolgual oriolgual force-pushed the update_dependencies branch from 67c71ea to df60352 Jun 21, 2019
@oriolgual oriolgual force-pushed the update_dependencies branch from df60352 to 0270c93 Jun 21, 2019
@oriolgual oriolgual removed the status: WIP label Jun 22, 2019
@josepjaume josepjaume merged commit eb0f95a into master Jun 22, 2019
29 checks passed
29 checks passed
ci/circleci: accountability Your tests passed on CircleCI!
Details
ci/circleci: admin Your tests passed on CircleCI!
Details
ci/circleci: api Your tests passed on CircleCI!
Details
ci/circleci: assemblies Your tests passed on CircleCI!
Details
ci/circleci: blogs Your tests passed on CircleCI!
Details
ci/circleci: budgets Your tests passed on CircleCI!
Details
ci/circleci: build_design_app Your tests passed on CircleCI!
Details
ci/circleci: build_test_app Your tests passed on CircleCI!
Details
ci/circleci: comments Your tests passed on CircleCI!
Details
ci/circleci: conferences Your tests passed on CircleCI!
Details
ci/circleci: consultations Your tests passed on CircleCI!
Details
ci/circleci: core Your tests passed on CircleCI!
Details
ci/circleci: debates Your tests passed on CircleCI!
Details
ci/circleci: forms Your tests passed on CircleCI!
Details
ci/circleci: generators Your tests passed on CircleCI!
Details
ci/circleci: initiatives Your tests passed on CircleCI!
Details
ci/circleci: main Your tests passed on CircleCI!
Details
ci/circleci: meetings Your tests passed on CircleCI!
Details
ci/circleci: pages Your tests passed on CircleCI!
Details
ci/circleci: participatory_processes Your tests passed on CircleCI!
Details
ci/circleci: proposals Your tests passed on CircleCI!
Details
ci/circleci: sortitions Your tests passed on CircleCI!
Details
ci/circleci: surveys Your tests passed on CircleCI!
Details
ci/circleci: system Your tests passed on CircleCI!
Details
ci/circleci: upload-coverage Your tests passed on CircleCI!
Details
ci/circleci: verifications Your tests passed on CircleCI!
Details
codeclimate 1 fixed issue
Details
codeclimate/diff-coverage 100% (80% threshold)
Details
codeclimate/total-coverage 98% (0.0% change)
Details
@josepjaume josepjaume deleted the update_dependencies branch Jun 22, 2019
@oriolgual oriolgual referenced this pull request Jun 25, 2019
oriolgual added a commit that referenced this pull request Jul 3, 2019
* Update dependencies

* Fix Faker deprecations

* Fix spec

* Add missing migration from Doorkeeper

* Always use latest Decidim Docker image

* Fix Rubocop issues

* Use Ruby grep

* Set specific names for scopes.

After debugging this for too many hours, I've concluded that if a scope
has an "s" in its name, for some reason I fail to understand, it is
escaped and represented as &#115 (which is an "s" for html entitites).
This seems to happen at browser level and I can't reproduce it otuside
the test environment.

* Remove deprecated PaperTrail config

* Don't run specs that depend on master when not on master
oriolgual added a commit that referenced this pull request Jul 3, 2019
* Update dependencies

* Fix Faker deprecations

* Fix spec

* Add missing migration from Doorkeeper

* Always use latest Decidim Docker image

* Fix Rubocop issues

* Use Ruby grep

* Set specific names for scopes.

After debugging this for too many hours, I've concluded that if a scope
has an "s" in its name, for some reason I fail to understand, it is
escaped and represented as &#115 (which is an "s" for html entitites).
This seems to happen at browser level and I can't reproduce it otuside
the test environment.

* Remove deprecated PaperTrail config

* Don't run specs that depend on master when not on master
oriolgual added a commit that referenced this pull request Jul 3, 2019
* Update dependencies

* Fix Faker deprecations

* Fix spec

* Add missing migration from Doorkeeper

* Always use latest Decidim Docker image

* Fix Rubocop issues

* Use Ruby grep

* Set specific names for scopes.

After debugging this for too many hours, I've concluded that if a scope
has an "s" in its name, for some reason I fail to understand, it is
escaped and represented as &#115 (which is an "s" for html entitites).
This seems to happen at browser level and I can't reproduce it otuside
the test environment.

* Remove deprecated PaperTrail config

* Don't run specs that depend on master when not on master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.