Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSV Import to Participatory Space Private Users #5304

Merged
merged 9 commits into from Sep 12, 2019

Conversation

@isaacmg410
Copy link
Contributor

isaacmg410 commented Aug 23, 2019

馃帺 What? Why?

To have the ability to upload a CSV with names and emails to upload a group of participants together. In this way an assembly admin or a superadmin can manage the private participants in a more agile way.

馃搶 Related Issues

馃搵 Subtasks

  • Add CHANGELOG entry
  • Add documentation regarding the feature
  • Upload a CSV with names and emails.
  • Send notification to a previously registered participant.
  • The management of private participants would be maintained. You can remove them, as well as upload more CSVs for new uploads.
  • Add tests
  • Another subtask

馃摲 Screenshots (optional)

Description

@isaacmg410 isaacmg410 requested a review from decidim/core as a code owner Aug 23, 2019
@isaacmg410 isaacmg410 self-assigned this Aug 23, 2019
@isaacmg410 isaacmg410 changed the title Improvements participatory space private users [WIP] Improvements participatory space private users Aug 23, 2019
@isaacmg410 isaacmg410 changed the title [WIP] Improvements participatory space private users Add CSV Import to Participatory Space Private Users Aug 26, 2019
isaacmg410 added 2 commits Aug 26, 2019
@isaacmg410

This comment has been minimized.

Copy link
Contributor Author

isaacmg410 commented Aug 27, 2019

@decidim/lot-core ready to review :)

isaacmg410 and others added 3 commits Sep 10, 2019
鈥_private_user_csv_job.rb

Co-Authored-By: Oriol Gual <oriolgual@users.noreply.github.com>
鈥space_private_user_import_csv.rb

Co-Authored-By: Oriol Gual <oriolgual@users.noreply.github.com>
@isaacmg410

This comment has been minimized.

Copy link
Contributor Author

isaacmg410 commented Sep 10, 2019

@oriolgual requested changes applied.

@isaacmg410

This comment has been minimized.

Copy link
Contributor Author

isaacmg410 commented Sep 12, 2019

@oriolgual can this be merged?

@oriolgual oriolgual merged commit e288149 into master Sep 12, 2019
29 checks passed
29 checks passed
ci/circleci: accountability Your tests passed on CircleCI!
Details
ci/circleci: admin Your tests passed on CircleCI!
Details
ci/circleci: api Your tests passed on CircleCI!
Details
ci/circleci: assemblies Your tests passed on CircleCI!
Details
ci/circleci: blogs Your tests passed on CircleCI!
Details
ci/circleci: budgets Your tests passed on CircleCI!
Details
ci/circleci: build_design_app Your tests passed on CircleCI!
Details
ci/circleci: build_test_app Your tests passed on CircleCI!
Details
ci/circleci: comments Your tests passed on CircleCI!
Details
ci/circleci: conferences Your tests passed on CircleCI!
Details
ci/circleci: consultations Your tests passed on CircleCI!
Details
ci/circleci: core Your tests passed on CircleCI!
Details
ci/circleci: debates Your tests passed on CircleCI!
Details
ci/circleci: forms Your tests passed on CircleCI!
Details
ci/circleci: generators Your tests passed on CircleCI!
Details
ci/circleci: initiatives Your tests passed on CircleCI!
Details
ci/circleci: main Your tests passed on CircleCI!
Details
ci/circleci: meetings Your tests passed on CircleCI!
Details
ci/circleci: pages Your tests passed on CircleCI!
Details
ci/circleci: participatory_processes Your tests passed on CircleCI!
Details
ci/circleci: proposals Your tests passed on CircleCI!
Details
ci/circleci: sortitions Your tests passed on CircleCI!
Details
ci/circleci: surveys Your tests passed on CircleCI!
Details
ci/circleci: system Your tests passed on CircleCI!
Details
ci/circleci: upload-coverage Your tests passed on CircleCI!
Details
ci/circleci: verifications Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 97% (80% threshold)
Details
codeclimate/total-coverage 98% (0.0% change)
Details
@oriolgual oriolgual deleted the improvements_participatory_space_private_users branch Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.