Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple choice answers in consultations #5356

Merged
merged 26 commits into from Sep 26, 2019

Conversation

@microstudi
Copy link
Contributor

microstudi commented Sep 23, 2019

馃帺 What? Why?

This PR implements this proposal in MetaDecidim:
https://meta.decidim.org/processes/roadmap/f/122/proposals/14696

It adds multi-choice support for consultations questions.
Introduces a new controller to configure a minimum and a maximum number of options allowed.
The votation page, in case of a multi-choice question, is no longer a Modal and displays several checkboxes with a general counter of number of answers still available.
Default behavior is to create 1-option questions and former modal is maintained.

馃搶 Related Issues

  • Related to #?
  • Fixes #?

馃搵 Subtasks

  • Add CHANGELOG entry
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

馃摲 Screenshots (optional)

image

image

microstudi added 21 commits Jul 2, 2019
# Conflicts:
#	decidim-consultations/config/locales/en.yml
#	decidim-consultations/lib/decidim/consultations/admin_engine.rb
@microstudi microstudi requested a review from decidim/core as a code owner Sep 23, 2019
microstudi added 2 commits Sep 23, 2019
microstudi added 2 commits Sep 26, 2019
@microstudi

This comment has been minimized.

Copy link
Contributor Author

microstudi commented Sep 26, 2019

@oriolgual I think I've addressed all the issues, can you take a look again? Thanks a lot!

@oriolgual oriolgual merged commit 9da3b75 into decidim:master Sep 26, 2019
0 of 3 checks passed
0 of 3 checks passed
ci/circleci: build_test_app CircleCI is running your tests
Details
ci/circleci: main CircleCI is running your tests
Details
codeclimate Code Climate is analyzing this code.
Details
@microstudi microstudi referenced this pull request Oct 1, 2019
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.