Allow multiple choice answers in consultations #5356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # decidim-consultations/config/locales/en.yml # decidim-consultations/lib/decidim/consultations/admin_engine.rb
oriolgual
suggested changes
Sep 25, 2019
decidim-consultations/app/commands/decidim/consultations/multiple_vote_question.rb
Show resolved
Hide resolved
decidim-consultations/app/commands/decidim/consultations/admin/update_question_configuration.rb
Outdated
Show resolved
Hide resolved
decidim-consultations/app/commands/decidim/consultations/multiple_vote_question.rb
Outdated
Show resolved
Hide resolved
decidim-consultations/app/commands/decidim/consultations/multiple_vote_question.rb
Outdated
Show resolved
Hide resolved
...nsultations/app/controllers/decidim/consultations/admin/question_configuration_controller.rb
Show resolved
Hide resolved
...im-consultations/app/controllers/decidim/consultations/question_multiple_votes_controller.rb
Outdated
Show resolved
Hide resolved
...im-consultations/app/controllers/decidim/consultations/question_multiple_votes_controller.rb
Outdated
Show resolved
Hide resolved
|
@oriolgual I think I've addressed all the issues, can you take a look again? Thanks a lot! |
oriolgual
previously approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR implements this proposal in MetaDecidim:
https://meta.decidim.org/processes/roadmap/f/122/proposals/14696
It adds multi-choice support for consultations questions.
Introduces a new controller to configure a minimum and a maximum number of options allowed.
The votation page, in case of a multi-choice question, is no longer a Modal and displays several checkboxes with a general counter of number of answers still available.
Default behavior is to create 1-option questions and former modal is maintained.
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)