Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix email notifications #5370

Merged
merged 2 commits into from Sep 28, 2019

Conversation

@oriolgual
Copy link
Member

commented Sep 26, 2019

馃帺 What? Why?

We were only preventing the creation of notifications, but an email was sent when a resource wasn't published.

馃搶 Related Issues

馃搵 Subtasks

  • Add CHANGELOG entry
  • Add tests
@oriolgual oriolgual marked this pull request as ready for review Sep 26, 2019
@oriolgual oriolgual requested a review from decidim/lot-core as a code owner Sep 26, 2019
@oriolgual oriolgual force-pushed the fix-notification-mailer branch from 8d5c19b to dbaee8f Sep 27, 2019
oriolgual added 2 commits Sep 26, 2019
鈥lished. Closes #5125
@oriolgual oriolgual force-pushed the fix-notification-mailer branch from dbaee8f to 61448e8 Sep 28, 2019
@oriolgual oriolgual merged commit 8a8bcb6 into master Sep 28, 2019
29 checks passed
29 checks passed
ci/circleci: accountability Your tests passed on CircleCI!
Details
ci/circleci: admin Your tests passed on CircleCI!
Details
ci/circleci: api Your tests passed on CircleCI!
Details
ci/circleci: assemblies Your tests passed on CircleCI!
Details
ci/circleci: blogs Your tests passed on CircleCI!
Details
ci/circleci: budgets Your tests passed on CircleCI!
Details
ci/circleci: build_design_app Your tests passed on CircleCI!
Details
ci/circleci: build_test_app Your tests passed on CircleCI!
Details
ci/circleci: comments Your tests passed on CircleCI!
Details
ci/circleci: conferences Your tests passed on CircleCI!
Details
ci/circleci: consultations Your tests passed on CircleCI!
Details
ci/circleci: core Your tests passed on CircleCI!
Details
ci/circleci: debates Your tests passed on CircleCI!
Details
ci/circleci: forms Your tests passed on CircleCI!
Details
ci/circleci: generators Your tests passed on CircleCI!
Details
ci/circleci: initiatives Your tests passed on CircleCI!
Details
ci/circleci: main Your tests passed on CircleCI!
Details
ci/circleci: meetings Your tests passed on CircleCI!
Details
ci/circleci: pages Your tests passed on CircleCI!
Details
ci/circleci: participatory_processes Your tests passed on CircleCI!
Details
ci/circleci: proposals Your tests passed on CircleCI!
Details
ci/circleci: sortitions Your tests passed on CircleCI!
Details
ci/circleci: surveys Your tests passed on CircleCI!
Details
ci/circleci: system Your tests passed on CircleCI!
Details
ci/circleci: upload-coverage Your tests passed on CircleCI!
Details
ci/circleci: verifications Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 99% (80% threshold)
Details
codeclimate/total-coverage 98% (0.0% change)
Details
@oriolgual oriolgual deleted the fix-notification-mailer branch Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can鈥檛 perform that action at this time.