Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixing #5402

Merged
merged 5 commits into from Oct 7, 2019

Conversation

@oriolgual
Copy link
Member

commented Oct 7, 2019

馃帺 What? Why?

Meeting presenter
There was an error in the meeting admin form when there was a validation problem, instead of using the submitted value we were using the value from the model.

Also, the meeting show wasn't properly rendering titles with hashtags.

Scopes filter
Fix error when trying to add more than one scope filter to search results.

API
Lock graphiql version, fixes regression.

馃搵 Subtasks

  • Add CHANGELOG entry
@oriolgual oriolgual requested a review from decidim/lot-core as a code owner Oct 7, 2019
oriolgual added 4 commits Oct 7, 2019
@oriolgual oriolgual force-pushed the fix-meeting-presenter branch from b09b488 to 96b9ff9 Oct 7, 2019
@oriolgual oriolgual changed the title Fix meeting presenter Bugfixing Oct 7, 2019
@oriolgual oriolgual merged commit 1e69e6e into master Oct 7, 2019
30 checks passed
30 checks passed
DEP All dependencies are resolved
ci/circleci: accountability Your tests passed on CircleCI!
Details
ci/circleci: admin Your tests passed on CircleCI!
Details
ci/circleci: api Your tests passed on CircleCI!
Details
ci/circleci: assemblies Your tests passed on CircleCI!
Details
ci/circleci: blogs Your tests passed on CircleCI!
Details
ci/circleci: budgets Your tests passed on CircleCI!
Details
ci/circleci: build_design_app Your tests passed on CircleCI!
Details
ci/circleci: build_test_app Your tests passed on CircleCI!
Details
ci/circleci: comments Your tests passed on CircleCI!
Details
ci/circleci: conferences Your tests passed on CircleCI!
Details
ci/circleci: consultations Your tests passed on CircleCI!
Details
ci/circleci: core Your tests passed on CircleCI!
Details
ci/circleci: debates Your tests passed on CircleCI!
Details
ci/circleci: forms Your tests passed on CircleCI!
Details
ci/circleci: generators Your tests passed on CircleCI!
Details
ci/circleci: initiatives Your tests passed on CircleCI!
Details
ci/circleci: main Your tests passed on CircleCI!
Details
ci/circleci: meetings Your tests passed on CircleCI!
Details
ci/circleci: pages Your tests passed on CircleCI!
Details
ci/circleci: participatory_processes Your tests passed on CircleCI!
Details
ci/circleci: proposals Your tests passed on CircleCI!
Details
ci/circleci: sortitions Your tests passed on CircleCI!
Details
ci/circleci: surveys Your tests passed on CircleCI!
Details
ci/circleci: system Your tests passed on CircleCI!
Details
ci/circleci: upload-coverage Your tests passed on CircleCI!
Details
ci/circleci: verifications Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codeclimate/diff-coverage 80% (80% threshold)
Details
codeclimate/total-coverage 98% (0.0% change)
Details
@oriolgual oriolgual deleted the fix-meeting-presenter branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can鈥檛 perform that action at this time.