Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/master export import participatory processes components #5424

Merged

Conversation

isaacmg410
Copy link
Contributor

@isaacmg410 isaacmg410 commented Oct 17, 2019

馃帺 What? Why?

Adds Component serialization capabilities to participatory spaces, including participatory processes.

馃搶 Related Issues

馃搵 Subtasks

  • Add CHANGELOG entry
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Export
  • Import
  • Test methods added to ComponentManifest
  • Implement and test specific_data serialization for Surveys: Questionnaire->questions->answer_options but not answers.

馃摲 Screenshots (optional)

@isaacmg410 isaacmg410 assigned aitorlb and tramuntanal and unassigned aitorlb Oct 17, 2019
tramuntanal added 3 commits Oct 17, 2019
[REFACTOR] Wrap Survey importation into a transaction.
[REFACTOR] Do not modify object, return new value instead.
@tramuntanal tramuntanal marked this pull request as ready for review Oct 21, 2019
@tramuntanal tramuntanal requested a review from as a code owner Oct 21, 2019
@tramuntanal
Copy link
Contributor

@tramuntanal tramuntanal commented Oct 23, 2019

This PR is ready for re-review @decidim/lot-core

@oriolgual oriolgual merged commit ba21195 into master Oct 23, 2019
29 checks passed
@oriolgual oriolgual deleted the feat/master_export_import_participatory_processes_components branch Oct 23, 2019
microstudi pushed a commit to Platoniq/decidim that referenced this issue Nov 6, 2019
鈥#5424)

* export import feature participatory processes

* add changelog

* fix codeclimate

* add line on bottom

* add components to export/import feature

* [REFACTOR] Wrap Component importation into a transaction.
[REFACTOR] Wrap Survey importation into a transaction.
[REFACTOR] Do not modify object, return new value instead.

* [REFACTOR] Pass lost `user`variable when extracting code into a method.

* Add changelog entry.

* [TEST] Adapt test to new Settings.

* [TEST] Get rid of removed trait.

* Update changelog entry.

* Rubocopify from master: RSpec/EmptyLineAfterExample: Add an empty line after it.

* Rubocopify from master: RSpec/EmptyLineAfterExample: Add an empty line after it (in decidim-blogs).
@virgile-dev
Copy link
Contributor

@virgile-dev virgile-dev commented Nov 28, 2019

@tramuntanal we are finalizing the testing of this feature on our side. First I'd like to thank you guys for the terrific work done here, this feature is really great.

We discussed migrating this code to 0.19 and extending the functionnality to assemblies when do you think you guys will be able to do it ?

Priority indicated with P1 (most urgent), P2, P3 (least urgent).

Here is a list of things of things that are not imported that should be :

Process info page

  • P3 Images url are not imported (as specified here)
  • P1 Announcement from the information page

Proposal configuration

  • P1 Specific global parameters are not imported (fields are set to default values)
  • P1 Proposal wizard help text are not imported ("New proposal help text", "Proposal wizard "Create" step help text", "Proposal wizard "Compare" step help text", "Proposal wizard "Complete" step help text", "Proposal wizard "Publish" step help text")
  • P1 Specific step parameters are not imported (checkbox are set to default values)
  • P1 Steps and global announcements are not imported
  • P1 Steps "Hashtags added to all proposals" are not imported
  • P1 Steps "Hashtags suggested to participants for new proposals" are not imported

Budget configuration

  • P2 Steps and Global Announcements are not imported
  • P2 Global parameters are not imported (fields are set to default values)
  • P2 Specific step parameters are not imported (checkbox are set to default values)

Survey configuration

  • P1 Steps and Global Announcements are not imported
  • P1 Global parameters are not imported (fields are set to default values)
  • P1 Specific step parameters are not imported (checkbox are set to default values)

Blog configuration

  • P2 Steps and Global Announcements are not imported
  • P2 Global parameters are not imported (fields are set to default values)
  • P2 Specific step parameters are not imported (checkbox are set to default values)

Meetings configuration

  • P1 Steps and Global Announcements are not imported
  • P1 Default registration terms are not imported
  • P1 Global parameters are not imported (fields are set to default values)
  • P1 Specific step parameters are not imported (checkbox are set to default values)

Accountability configuration

  • Global parameters are not imported (fields are set to default values)
    • P3 芦聽Introduction聽禄 is not saved
    • P3 芦聽Name for "Categories"聽禄 is not saved
    • [聽]聽P3 芦聽Name for "Subcategories"聽禄 is not saved
    • [聽]聽P3 芦聽Name for "Results"聽禄 is not saved
    • P3 芦聽Name for "Projets"聽禄 is not saved
  • P3 Specific step parameters are not imported (checkbox are set to default values)

Also here is a list of bugs we noticed

  • P1 Scopes are activated even if not activated in the orginal process
  • P1 When importing a process a void process group is created and the process is linked to it.

Capture d鈥檈虂cran 2019-11-28 a虁 16 33 54

Capture d鈥檈虂cran 2019-11-28 a虁 16 34 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants