Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include drafts in sortitions #5434

Merged
merged 5 commits into from Oct 21, 2019

Conversation

@armandfardeau
Copy link
Contributor

armandfardeau commented Oct 20, 2019

馃帺 What? Why?

The sortition component shouldn't select a proposal that hasn't been published by the user.

馃搶 Related Issues

馃搵 Subtasks

  • Add CHANGELOG entry
  • Add tests
@armandfardeau armandfardeau requested a review from decidim/core as a code owner Oct 20, 2019
armandfardeau and others added 4 commits Oct 20, 2019
@oriolgual oriolgual merged commit aa14989 into decidim:master Oct 21, 2019
0 of 3 checks passed
0 of 3 checks passed
ci/circleci: build_test_app CircleCI is running your tests
Details
ci/circleci: main CircleCI is running your tests
Details
codeclimate Code Climate is analyzing this code.
Details
microstudi added a commit to Platoniq/decidim that referenced this pull request Nov 6, 2019
* Don't include drafts in sortitions

* Add changelog entry

* Fix rubocop offenses

* Update participatory_space_proposals_spec.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.