Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Duplicate results in Decidim::HasPrivateUsers::visible_for(user) #5462

Conversation

@aitorlb
Copy link
Contributor

aitorlb commented Oct 29, 2019

馃帺 What? Why?

I introduced this bug in a refactor and there were no tests to catch it. Affected ParticipatoryProcess.

馃搶 Related Issues

  • Related to #3638 (This bug has already been fixed in the past)
  • Related to #5047 (The refactor that introduced the bug 鈥攁gain)

馃搵 Subtasks

  • Add CHANGELOG entry
  • Add tests

馃摲 Screenshots (optional)

duplicates-min

@aitorlb aitorlb requested a review from decidim/core as a code owner Oct 29, 2019
@aitorlb

This comment has been minimized.

Copy link
Contributor Author

aitorlb commented Oct 29, 2019

I'll do backports to 0.18.1 and 0.19.0.

@oriolgual

This comment has been minimized.

Copy link
Member

oriolgual commented Oct 29, 2019

Please rebase in order to fix the CI errors, I fixed them in #5459

@aitorlb aitorlb force-pushed the CodiTramuntana:fix/has_private_users_visible_for_duplicates branch 2 times, most recently from 6bdffda to 31faf08 Oct 29, 2019
I've run into the following problem multiple times since adding `.distinct`:
'ERROR: for SELECT DISTINCT, <SCOPE_EXPRESSION> expressions must appear in select list'.
@aitorlb aitorlb force-pushed the CodiTramuntana:fix/has_private_users_visible_for_duplicates branch from 31faf08 to 63c0387 Oct 29, 2019
aitorlb added 2 commits Nov 4, 2019
Copy link
Contributor

tramuntanal left a comment

Good catch!

@tramuntanal tramuntanal merged commit e4d26e7 into decidim:master Nov 5, 2019
26 checks passed
26 checks passed
ci/circleci: accountability Your tests passed on CircleCI!
Details
ci/circleci: admin Your tests passed on CircleCI!
Details
ci/circleci: api Your tests passed on CircleCI!
Details
ci/circleci: assemblies Your tests passed on CircleCI!
Details
ci/circleci: blogs Your tests passed on CircleCI!
Details
ci/circleci: budgets Your tests passed on CircleCI!
Details
ci/circleci: build_design_app Your tests passed on CircleCI!
Details
ci/circleci: build_test_app Your tests passed on CircleCI!
Details
ci/circleci: comments Your tests passed on CircleCI!
Details
ci/circleci: conferences Your tests passed on CircleCI!
Details
ci/circleci: consultations Your tests passed on CircleCI!
Details
ci/circleci: core Your tests passed on CircleCI!
Details
ci/circleci: debates Your tests passed on CircleCI!
Details
ci/circleci: forms Your tests passed on CircleCI!
Details
ci/circleci: generators Your tests passed on CircleCI!
Details
ci/circleci: initiatives Your tests passed on CircleCI!
Details
ci/circleci: main Your tests passed on CircleCI!
Details
ci/circleci: meetings Your tests passed on CircleCI!
Details
ci/circleci: pages Your tests passed on CircleCI!
Details
ci/circleci: participatory_processes Your tests passed on CircleCI!
Details
ci/circleci: proposals Your tests passed on CircleCI!
Details
ci/circleci: sortitions Your tests passed on CircleCI!
Details
ci/circleci: surveys Your tests passed on CircleCI!
Details
ci/circleci: system Your tests passed on CircleCI!
Details
ci/circleci: upload-coverage Your tests passed on CircleCI!
Details
ci/circleci: verifications Your tests passed on CircleCI!
Details
@tramuntanal tramuntanal deleted the CodiTramuntana:fix/has_private_users_visible_for_duplicates branch Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.