Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

signup form styles for @nickname with validation #5495

Merged
merged 3 commits into from Nov 18, 2019

Conversation

@agustibr
Copy link
Contributor

agustibr commented Nov 14, 2019

馃帺 What? Why?

add a prefix @ in the nickname field

馃搶 Related Issues

馃搵 Subtasks

  • Add CHANGELOG entry
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

馃摲 Screenshots (optional)

Captura de pantalla de 2019-11-14 12-36-55

Captura de pantalla de 2019-11-14 12-37-31

@agustibr agustibr force-pushed the layout/nickname_arroba_input_group_prefix branch from c9f8bc4 to 2b5b776 Nov 14, 2019
@agustibr agustibr force-pushed the layout/nickname_arroba_input_group_prefix branch from 2b5b776 to 9dc07a2 Nov 14, 2019
Copy link
Contributor

tramuntanal left a comment

When there is a validation error from the server the css somehow breaks:
image

@tramuntanal

This comment has been minimized.

Copy link
Contributor

tramuntanal commented Nov 14, 2019

Curiously when I execute in my local development it works. The capture is from the html that capybara generates for system tests. Let's consider it ok.

@agustibr agustibr marked this pull request as ready for review Nov 15, 2019
@tramuntanal tramuntanal merged commit 50901fd into master Nov 18, 2019
27 checks passed
27 checks passed
DEP All dependencies are resolved
ci/circleci: accountability Your tests passed on CircleCI!
Details
ci/circleci: admin Your tests passed on CircleCI!
Details
ci/circleci: api Your tests passed on CircleCI!
Details
ci/circleci: assemblies Your tests passed on CircleCI!
Details
ci/circleci: blogs Your tests passed on CircleCI!
Details
ci/circleci: budgets Your tests passed on CircleCI!
Details
ci/circleci: build_design_app Your tests passed on CircleCI!
Details
ci/circleci: build_test_app Your tests passed on CircleCI!
Details
ci/circleci: comments Your tests passed on CircleCI!
Details
ci/circleci: conferences Your tests passed on CircleCI!
Details
ci/circleci: consultations Your tests passed on CircleCI!
Details
ci/circleci: core Your tests passed on CircleCI!
Details
ci/circleci: debates Your tests passed on CircleCI!
Details
ci/circleci: forms Your tests passed on CircleCI!
Details
ci/circleci: generators Your tests passed on CircleCI!
Details
ci/circleci: initiatives Your tests passed on CircleCI!
Details
ci/circleci: main Your tests passed on CircleCI!
Details
ci/circleci: meetings Your tests passed on CircleCI!
Details
ci/circleci: pages Your tests passed on CircleCI!
Details
ci/circleci: participatory_processes Your tests passed on CircleCI!
Details
ci/circleci: proposals Your tests passed on CircleCI!
Details
ci/circleci: sortitions Your tests passed on CircleCI!
Details
ci/circleci: surveys Your tests passed on CircleCI!
Details
ci/circleci: system Your tests passed on CircleCI!
Details
ci/circleci: verifications Your tests passed on CircleCI!
Details
codeclimate All good!
Details
@tramuntanal tramuntanal deleted the layout/nickname_arroba_input_group_prefix branch Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.