Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing indexs on foreign keys #5885

Merged
merged 2 commits into from Mar 26, 2020
Merged

Conversation

@mrcasals
Copy link
Contributor

mrcasals commented Mar 20, 2020

馃帺 What? Why?

This PR uses part of https://github.com/gregnavis/active_record_doctor to generate migrations to add missing indexs on foreign keys.

The gem has more features, but I've only used part of them.

馃搶 Related Issues

None

馃搵 Subtasks

  • Add CHANGELOG entry
@mrcasals mrcasals force-pushed the chores/add-missing-indexs branch from 93c7274 to 8d66039 Mar 20, 2020
@mrcasals

This comment has been minimized.

Copy link
Contributor Author

mrcasals commented Mar 20, 2020

I've rebased this PR to include #5883, which fixes the workflows builds. Please merge that one first!

@mrcasals mrcasals self-assigned this Mar 20, 2020
@mrcasals mrcasals marked this pull request as ready for review Mar 25, 2020
mrcasals added 2 commits Mar 20, 2020
@mrcasals mrcasals force-pushed the chores/add-missing-indexs branch from 8d66039 to 0b1193b Mar 25, 2020
@mrcasals

This comment has been minimized.

Copy link
Contributor Author

mrcasals commented Mar 25, 2020

@decidim/core can you check this please? 馃槃

@tramuntanal tramuntanal merged commit 2da1a7b into develop Mar 26, 2020
26 of 27 checks passed
26 of 27 checks passed
Tests Tests
Details
Tests Tests
Details
Tests Tests
Details
Tests Tests
Details
Tests Tests
Details
Tests Tests
Details
Tests Tests
Details
Tests Tests
Details
Tests Tests
Details
Tests Tests
Details
Tests Tests
Details
Tests Tests
Details
Tests
Details
Tests Tests
Details
Lint code
Details
Tests
Details
Tests Tests
Details
Tests Tests
Details
Tests Tests
Details
Tests Tests
Details
Tests Tests
Details
Tests Tests
Details
Tests Tests
Details
Tests Tests
Details
Tests Tests
Details
Tests Tests
Details
ci/circleci: Build Error Your tests failed on CircleCI
Details
@tramuntanal tramuntanal deleted the chores/add-missing-indexs branch Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can鈥檛 perform that action at this time.