New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design app fixes after Webpacker installation #7935
Conversation
Actually, @ferblape, why not just commit the files? Wouldn't that be safer for anyone using this app? It feels strange that I need to manually run the command to install Webpacker to the application when the app is already there 😕 |
I see your point, it's similar to the Gemfile case, both the design app and decidim share the Gemfile and it's commited, right? I didn't want to commit it to avoid the files to be outdated, but I guess that's something that can be prevented with a test or a check in the release process. What do you think? |
Yeah, sounds good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 41187 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 41190 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 41193 lines exceeds the maximum allowed for the inline comments feature.
@mrcasals ready to review again. PR description updated with the new approach and updated docs. Also, please check a test I've added in system/ to verify package.json is synchronized 😄 |
Nice, looks good to me! |
🎩 What? Why?
This PR fixes a couple of issues related with #7733
As a summary, now the process is a bit long:
📌 Related Issues
Testing
You should be able to see the design app working again 😅
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/
.📷 Screenshots
Please add screenshots of the changes you're proposing