Align UI groups filtering with the rest of decidim #8105
Conversation
1d9a471 to
91660e1
Compare
|
Hello @alecslupu |
|
@andreslucena This PR is doing exactly what you have mentioned. I had it left in Draft state as i was not able to find time to fill in the description. @leio10, this can be reviewed. |
|
I couldn't actually try this locally as I have an error when regenerating the development_app:
Although this isn't critical as this was solved already in |
91660e1 to
ac0ac6b
Compare
|
@andreslucena I just rebased the current branch with decidim/develop branch. |
Awesome, thanks @alecslupu. I've tried this locally and found a bug: When clicking in the State column it doesn't sort correctly. Could you please check that out? Thanks |
|
@carolromero , @andreslucena This can be tested on http://alecslupu.go.ro:3309/ (default decidim admin credentials) |
Ok, I tested this and I've detected a bug that I see it wasn't solved. Sorting by the state doesn't work. Can you please check this out @alecslupu 🙏🏽 ? Thanks |
ac0ac6b to
aa50bd8
Compare
|
@andreslucena the fixes have been put in place. |
Awesome, it works correctly 🚀 🚀 |
leio10
left a comment
There was a problem hiding this comment.
Looks good! 👏
Please @alecslupu, can you add some tests for the ordering and filtering of user groups? Thanks!
aa50bd8 to
570c987
Compare
570c987 to
27f43a5
Compare
leio10
left a comment
There was a problem hiding this comment.
Awesome @alecslupu!! LGTM!

🎩 What? Why?
Currently, the user groups page is displaying a one of a type filtering UI, and this PR aims to fix the issue, while adding also sorting options for groups module.

It replaces the
with the following information:
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
