Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the RSpec/RepeatedExampleGroupDescription rubocop cop #8704

Merged
merged 5 commits into from Jan 12, 2022

Conversation

andreslucena
Copy link
Member

馃帺 What? Why?

As #6499 says:

PR #5785 disabled the RSpec/RepeatedExampleGroupDescription cop, but it is a good way to reduce duplicated code in rspec tests.

馃搶 Related Issues

Testing

Before (with the cop enabled)
Inspecting 6110 files
6110 files inspected, 47 offenses detected, 8 offenses auto-correctable
After (with the cop enabled)
Inspecting 6110 files
(...)
6110 files inspected, no offenses detected

鈾ワ笍 Thank you!

@alecslupu
Copy link
Contributor

From pipeline perspective, there is only one failing check caused by a configuration issue.

@andreslucena andreslucena added the type: internal PRs that aren't necessary to add to the CHANGELOG for implementers label Jan 12, 2022
@andreslucena andreslucena merged commit 2ec4e59 into develop Jan 12, 2022
@andreslucena andreslucena deleted the test/rubocop-rspec-repeated branch January 12, 2022 12:04
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: internal PRs that aren't necessary to add to the CHANGELOG for implementers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable RSpec/RepeatedExampleGroupDescription
2 participants