Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow admins to disable email notifications for reported users #9072

Merged

Conversation

roxanaopr
Copy link
Contributor

As an admin/moderator I want to be able to switch off notifications coming from reported users via my profile -> notifications settings so that I can make sure I am following the information I am interested in.

Currently, there is an option for admins/moderators in order to switch off receiving the email notifications related to reported content, and we want to adjust it to also take into account reported users.
We will also need to change the text from "I want to receive an email every time something is reported for moderation." to "I want to receive an email every time something is reported for moderation."

🎩 What? Why?

Please describe your pull request.

πŸ“Œ Related Issues

Meata proposal: https://meta.decidim.org/processes/roadmap/f/122/proposals/16938

Testing

Describe the best way to test or validate your PR.

πŸ“‹ Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • βœ”οΈ DO check open PR's to avoid duplicates.
  • βœ”οΈ DO keep pull requests small so they can be easily reviewed.
  • βœ”οΈ DO build locally before pushing.
  • βœ”οΈ DO make sure tests pass.
  • βœ”οΈ DO make sure any new changes are documented in docs/.
  • βœ”οΈ DO add and modify seeds if necessary.
  • βœ”οΈ DO add CHANGELOG upgrade notes if required.
  • βœ”οΈ DO add to GraphQL API if there are new public fields.
  • βœ”οΈ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

πŸ“· Screen

Screenshot from 2022-03-22 15-48-23
shots

β™₯️ Thank you!

Copy link
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks great to me but could you address the one small change as well as my question below?

Gemfile.lock Outdated Show resolved Hide resolved
Copy link
Contributor

@ahukkanen ahukkanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@ahukkanen
Copy link
Contributor

I'll also let @andreslucena have a look because he's been marked as a reviewer.

Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘πŸ½ πŸ‘πŸ½

@andreslucena andreslucena changed the title Setting to switch off receiving the email notifications for reported users Allow admins to switch off receiving the email notifications for reported users Mar 28, 2022
@andreslucena andreslucena added module: core type: feature PRs or issues that implement a new feature labels Mar 28, 2022
@andreslucena andreslucena changed the title Allow admins to switch off receiving the email notifications for reported users Allow admins to disable email notifications for reported users Mar 28, 2022
@andreslucena andreslucena merged commit 4f8f8c4 into decidim:develop Mar 28, 2022
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: core type: feature PRs or issues that implement a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants