Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Faraday to 1.0.0 #68

Merged
merged 3 commits into from
Apr 17, 2020
Merged

Conversation

bidluo
Copy link
Contributor

@bidluo bidluo commented Mar 1, 2020

The current version (0.15.4) is out of date and doesn't fully support Ruby 2.7.
This change is primarily targeted to fix the deprecation warnings from faraday.

@sabman
Copy link
Member

sabman commented Mar 1, 2020

Thanks @bidluo can we also add 2.7 to the travis-ci?

@bidluo
Copy link
Contributor Author

bidluo commented Mar 1, 2020

@sabman done but looks like Faraday depends on ruby >= 2.3 (and fcm is ruby >= 2.0.0) so I think this will be up to you/maintainers to decide the outcome of this PR

@sabman
Copy link
Member

sabman commented Mar 1, 2020

might be time to get a new minor release 0.1.0 with only ruby 2.4+ support. What do the others? @kashif?

@sabman
Copy link
Member

sabman commented Mar 1, 2020

or better still a major version release 1.0.0. otherwise people might accidentally upgrade and break stuff.

@kashif
Copy link
Contributor

kashif commented Mar 1, 2020

👍

@v-kolesnikov
Copy link

@bidluo @bidluo Hi guys! Could I help you with this work? What the trouble?

@bidluo
Copy link
Contributor Author

bidluo commented Apr 15, 2020

@v-kolesnikov Nah seems fine, needs maintainers to merge

See #70 which needs to be merged before this

@sabman
Copy link
Member

sabman commented Apr 17, 2020

OK gonna merge this and make a new major release

@sabman sabman merged commit b64f836 into decision-labs:master Apr 17, 2020
@dankimio
Copy link

@sabman Any updates? Can we at least publish a beta version of 1.0?

@sabman
Copy link
Member

sabman commented May 12, 2020 via email

@dankimio
Copy link

dankimio commented May 15, 2020

@sabman I could help with this if you can add me to the repo and RubyGems

@sabman
Copy link
Member

sabman commented May 16, 2020

@dankimio I've pushed a release but we've added you to the team as well, thanks again for your patience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants