…n if $puppetmaster_ensure_version was not defined.
…er version through puppetmaster_ensure_version (such as through backports)
… removed for public use or incorporated into the puppet module" This isn't something we want to keep This reverts commit bc4fa29.
… for public use or incorporated into the puppet module
Mar 29 14:08:23 puppetmaster puppet-master: Unrecognised escape sequence '\%' in file /etc/puppet/modules/puppet/manifests/cron/linux.pp at line 17
…c by pulling 2 bytes from /dev/urandom, giving them to od which turns them into unsigned decimals, and then we bitshift the output, either by 5 or 6 depending on if we are replacing $RANDOM/1000*60 (right sift by 5 is the same as dividing by 2^N, or /32) or $RANDOM/2000*60 (range of [0,983]) Thanks to dkg for working through this with me, not only did he come up with it faster than a human brain should be able to function, he had the patience to explain all the individual pieces that I did not understand to me.
…erg:|^crit:) in the output from the puppet run doesn't leave us with a '1' return code from grep. On Debian Squeeze systems, this problem would result in cron reporting that the cron command failed with an exit status 1: /USR/SBIN/CRON: (CRON) error (grandchild #24108 failed with exit status 1) This was because grep returns a '1' if it fails to find a match. We don't want the failure to find failure messages to produce a failure, so this checks the return code of the grep and fixes it to be '0' if there were no such failure log messages. This is a bit ugly, if you ask me. We are already, unfortunately, swallowing the puppetd return code with the grep. It seems like these sorts of log messages should be retrieved via reports, logcheck, or something other than this grep of the output of the cronjob.
…ay it is done to set a flag so that squeeze has the service stopped, but lenny does not
$puppet_ensure_version to a backported version and your pinning was setup so that you dont pull any packages unless explicit (I believe this is the default), then you will end up seeing things like this: The following packages have unmet dependencies: puppet: Depends: puppet-common (= 2.6.2-4~bpo50+1) but 2.6.2-1~bpo50+1 is to be installed E: Broken packages at /etc/puppet/modules/puppet/manifests/linux.pp:6 this commit adds the $puppet_ensure_version test in debian.pp to make sure that the puppet-common package is also following this request
…ems to have been a mistake in a merge commit This reverts commit bb8ede5.
…o distinguish between different linux distros
…ually using the filename puppetd.cron
…etc/cron.d/puppetd.cron file resource and move the override from manifests/debian.pp. /etc/cron.d/puppetd.cron is not a valid cronjob according to the run-parts system that Debian uses to decide what is valid, as a result if you were to 'include puppet::cron' in your manifests on a debian/debian-derived system, then a cronjob would be created that would never be executed.
…p reports on a monthly basis (by default)
…efault that is shipped with the puppet module had it set to "START=yes". This commit reverts that to the packaged default. It would probably be better not to ship the exact duplicate of the package's /etc/default/puppet, but rather do something else, when things that are other than the default need to be changed.