Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
branch: master
Commits on Jun 1, 2011
  1. @pietro

    Fix bug where puppetmaster-common was only considered for installatio…

    pietro authored
    …n if $puppetmaster_ensure_version was not defined.
Commits on May 17, 2011
  1. @pietro

    Fix typo.

    pietro authored
Commits on Apr 22, 2011
  1. @micah

    fix problem where you are not on wheezy or sid, but you install a new…

    micah authored
    …er version through puppetmaster_ensure_version (such as through backports)
  2. @micah

    Revert "Declared the inclusion of an external package. This should be…

    micah authored
    … removed for public use or incorporated into the puppet module"
    
    This isn't something we want to keep
    
    This reverts commit bc4fa29.
  3. @fugit
  4. @fugit
  5. @fugit
  6. @fugit

    Declared the inclusion of an external package. This should be removed…

    fugit authored
    … for public use or incorporated into the puppet module
Commits on Apr 13, 2011
  1. @fugit

    removed errant space

    fugit authored
  2. @fugit
Commits on Mar 29, 2011
  1. @micah

    the % needs to be double-escaped so puppet doesn't complain like this:

    micah authored
    Mar 29 14:08:23 puppetmaster puppet-master[26637]: Unrecognised escape sequence '\%' in file /etc/puppet/modules/puppet/manifests/cron/linux.pp at line 17
  2. percent is magic in crontabs and needs to be escaped

    Matt Taggart authored
Commits on Mar 28, 2011
  1. @micah
  2. @micah
  3. @micah
Commits on Mar 22, 2011
  1. @micah
  2. @micah
  3. @micah
Commits on Mar 16, 2011
  1. @micah

    instead of using $RANDOM, which isn't POSIX, we get even more esoteri…

    micah authored
    …c by pulling 2 bytes from /dev/urandom, giving them to od which turns them into unsigned decimals, and then we bitshift the output, either by 5 or 6 depending on if we are replacing $RANDOM/1000*60 (right sift by 5 is the same as dividing by 2^N, or /32) or $RANDOM/2000*60 (range of [0,983])
    
    Thanks to dkg for working through this with me, not only did he come up with it faster than a human brain should be able to function, he had the patience to explain all the individual pieces that I did not understand to me.
Commits on Mar 15, 2011
  1. @micah

    change the cronjob so that the failure to find any (^err:|^alert:|^em…

    micah authored
    …erg:|^crit:) in the output from the puppet run doesn't leave us with a '1' return code from grep.
    
    On Debian Squeeze systems, this problem would result in cron reporting that the cron command failed with an exit status 1:
    
    /USR/SBIN/CRON[24107]: (CRON) error (grandchild #24108 failed with exit status 1)
    
    This was because grep returns a '1' if it fails to find a match. We don't want the failure to find failure messages to produce a failure, so this checks the return code of the grep and fixes it to be '0' if there were no such failure log messages.
    
    This is a bit ugly, if you ask me. We are already, unfortunately, swallowing the puppetd return code with the grep. It seems like these sorts of log messages should be retrieved via reports, logcheck, or something other than this grep of the output of the cronjob.
Commits on Mar 1, 2011
  1. @micah

    the debian-specific case doesn't work for squeeze, so re-factor the w…

    micah authored
    …ay it is
    
    done to set a flag so that squeeze has the service stopped, but lenny does not
Commits on Feb 28, 2011
  1. @micah

    debian's puppet depends on puppet-common, but if you were to set

    micah authored
    $puppet_ensure_version to a backported version and your pinning was setup so
    that you dont pull any packages unless explicit (I believe this is the default),
    then you will end up seeing things like this:
    
    The following packages have unmet dependencies:
      puppet: Depends: puppet-common (= 2.6.2-4~bpo50+1) but 2.6.2-1~bpo50+1 is to be installed
    E: Broken packages
     at /etc/puppet/modules/puppet/manifests/linux.pp:6
    
    this commit adds the $puppet_ensure_version test in debian.pp to make sure that
    the puppet-common package is also following this request
Commits on Feb 16, 2011
  1. @micah
Commits on Feb 14, 2011
  1. @micah

    Revert "debian's puppet initscript has status functionality", this se…

    micah authored
    …ems to have been a mistake in a merge commit
    
    This reverts commit bb8ede5.
Commits on Feb 11, 2011
  1. @micah

    fact needs to check now for $operatingsystem, not $kernel, in order t…

    micah authored
    …o distinguish between different linux distros
  2. @micah
  3. @micah

    this cleanup isn't a good idea for the other linux people who are act…

    micah authored
    …ually using the filename puppetd.cron
  4. @micah

    make a puppet::cron::debian class that includes the override of the /…

    micah authored
    …etc/cron.d/puppetd.cron file resource and move the override from manifests/debian.pp.
    
    /etc/cron.d/puppetd.cron is not a valid cronjob according to the run-parts system that Debian uses to decide what is valid, as a result if you were to 'include puppet::cron' in your manifests on a debian/debian-derived system, then a cronjob would be created that would never be executed.
Commits on Jan 17, 2011
  1. @micah

    fix location of puppet reports in cronjob that is run daily to cleanu…

    micah authored
    …p reports on a monthly basis (by default)
Commits on Jan 11, 2011
  1. @micah

    on debian, the default /etc/default/puppet file has "START=no", the d…

    micah authored
    …efault that is shipped with the puppet module had it set to "START=yes". This commit reverts that to the packaged default.
    
    It would probably be better not to ship the exact duplicate of the package's /etc/default/puppet, but rather do something else, when things that are other than the default need to be changed.
  2. @micah
  3. @micah
  4. @micah
  5. @micah

    update README to reflect the module pre-requirements needed for puppe…

    micah authored
    …t::puppetmaster::storeconfigs
  6. @micah

    fix the bc dependency (closes: #2690)

    micah authored
    this is done by removing the hacky `if !defined` on the bc package by removing the package dependency altogether and replacing the places where it is used by shell built-in math functions.
    
    this is a follow-up commit to 1455b1f
Something went wrong with that request. Please try again.