Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[highlight-code] display optionally line numbers #115

Closed
peterpeterparker opened this issue May 14, 2019 · 2 comments

Comments

@peterpeterparker
Copy link
Contributor

commented May 14, 2019

Description

Moreover than being able to highlight specific rows when using the code component (which is already implemented) it would be interesting to have an option to display automatically the line number at the begin of each row

0. export class Something() {
1.
2.    const hello: string = 'Yolo';
3. }

Tech info

The highlight-component finds place in webcomponents/highlight-code/. This feature should probably be implemented in the same way as the addHighlight() function.

Get started

Interested to get involved and to try to implement this feature? Ping me if you have any questions or need help to get started, David (@peterpeterparker or twitter.com/daviddalbusco) 😃

@peterpeterparker peterpeterparker self-assigned this May 14, 2019

@peterpeterparker peterpeterparker changed the title Add an option display a line number at the begin of each slides in the code component Add an option display a line number at the begin of each lines in the code component May 14, 2019

@peterpeterparker peterpeterparker removed their assignment Jul 25, 2019

@peterpeterparker peterpeterparker changed the title Add an option display a line number at the begin of each lines in the code component [code] Add an option display a line number at the begin of each lines in the code component Jul 25, 2019

@peterpeterparker peterpeterparker changed the title [code] Add an option display a line number at the begin of each lines in the code component [highlight-code] Add an option display a line number at the begin of each lines in the code component Jul 25, 2019

@peterpeterparker peterpeterparker changed the title [highlight-code] Add an option display a line number at the begin of each lines in the code component [highlight-code] display optionally line numbers Jul 26, 2019

@peterpeterparker

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2019

@StefanNieuwenhuis will give a try 👍

peterpeterparker added a commit that referenced this issue Jul 30, 2019

peterpeterparker added a commit that referenced this issue Jul 30, 2019

@peterpeterparker

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

@StefanNieuwenhuis solved this feature and an update of the component has been published to npmjs 👍

@peterpeterparker peterpeterparker added this to the studio milestone Jul 30, 2019

peterpeterparker added a commit that referenced this issue Jul 30, 2019

peterpeterparker added a commit that referenced this issue Jul 30, 2019

peterpeterparker added a commit that referenced this issue Jul 30, 2019

peterpeterparker added a commit that referenced this issue Jul 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.