Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Transition animation with "fade effect" #70

Open
peterpeterparker opened this issue Mar 6, 2019 · 3 comments

Comments

@peterpeterparker
Copy link
Contributor

commented Mar 6, 2019

Description

Currently the transition between slide occurs through a "swipe animation" (right to left or left to right in RTL).

It would be cool to have optionally an other transition effect respectively to be able to set the animation as a "fade effect" between slides.

Tech info

This feature should be implement in the /webcomponents/core/ components of DeckDeckGo. It needs probably a bit of CSS and the transform property should be handled differently.

Get started

Interested to get involved and to try to implement this feature? Ping me if you have any questions or need help to get started, David (@peterpeterparker or twitter.com/daviddalbusco) 😃

@peterpeterparker peterpeterparker changed the title Fade effect [core] Transition animation with "fade effect" Jul 25, 2019

@peterpeterparker

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2019

The current "slide" effect

ezgif com-video-to-gif

@perceptron007

This comment has been minimized.

Copy link

commented Jul 31, 2019

@peterpeterparker I would like to help you out on this issue. Can you give me a few pointers where should I start?
Also, I am going to take a look at the codebase for getting familiar but would be helpful if you can tell me what exactly needed to be done.

@peterpeterparker

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

cool @perceptron007 👍

This feature should be implemented in our core web components

Important: all our components should remains as much as possible agnostic, therefore it should be implemented without adding any dependencies, it's more fun ;)

About where to start, you could have a look at the current move transform function. I guess that once a new option added, if this option is set, the transform should not be performed that way and instead the "fade effect" should occurs

Likewise probably, if the option is set, nothing should happens when the slide is moved

Let me know if you need more info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.