From 18155fe85899643fee625525bb482c020fe46f1c Mon Sep 17 00:00:00 2001 From: peterpeterparker Date: Thu, 11 Mar 2021 17:54:47 +0100 Subject: [PATCH] fix: notes not persisted anymore - listener has to be attached higher --- .../app/handlers/editor/events/deck/deck-events.handler.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/studio/src/app/handlers/editor/events/deck/deck-events.handler.ts b/studio/src/app/handlers/editor/events/deck/deck-events.handler.ts index 31bddd7b8..bbb983419 100644 --- a/studio/src/app/handlers/editor/events/deck/deck-events.handler.ts +++ b/studio/src/app/handlers/editor/events/deck/deck-events.handler.ts @@ -73,7 +73,6 @@ export class DeckEventsHandler { this.mainRef.addEventListener('imgDidChange', this.onCustomEventChange, false); this.mainRef.addEventListener('linkCreated', this.onCustomEventChange, false); this.mainRef.addEventListener('drrDidChange', this.onCustomEventChange, false); - this.mainRef.addEventListener('notesDidChange', this.onSlideChange, false); if (!document) { return; @@ -84,6 +83,7 @@ export class DeckEventsHandler { document.addEventListener('slideDelete', this.onSlideDelete, false); document.addEventListener('deckDidChange', this.onDeckChange, false); document.addEventListener('deckNeedChange', this.onDeckNeedChange, false); + document.addEventListener('notesDidChange', this.onSlideChange, false); } destroy() { @@ -97,7 +97,6 @@ export class DeckEventsHandler { this.mainRef.removeEventListener('imgDidChange', this.onCustomEventChange, true); this.mainRef.removeEventListener('linkCreated', this.onCustomEventChange, true); this.mainRef.removeEventListener('drrDidChange', this.onCustomEventChange, true); - this.mainRef.removeEventListener('notesDidChange', this.onSlideChange, true); if (!document) { return; @@ -108,6 +107,7 @@ export class DeckEventsHandler { document.removeEventListener('slideDelete', this.onSlideDelete, true); document.removeEventListener('deckDidChange', this.onDeckChange, true); document.removeEventListener('deckNeedChange', this.onDeckNeedChange, true); + document.removeEventListener('notesDidChange', this.onSlideChange, true); } private onSlideDidLoad = async ($event: CustomEvent) => { @@ -140,6 +140,8 @@ export class DeckEventsHandler { }; private onSlideChange = async ($event: CustomEvent) => { + console.log('yo', $event); + if (!$event || !$event.detail) { return; }