Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line numbers to highlight code #213

Merged
merged 4 commits into from Jul 30, 2019

Conversation

@StefanNieuwenhuis
Copy link
Contributor

commented Jul 29, 2019

@peterpeterparker

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

@StefanNieuwenhuis wow looks really support cool, I didn't thought about the border-right and that such a nice add-ons. Also super cool to have think about the documentation 👍

I just noticed two issues, if you would not mind having a look? otherwise I'm happy to take the code as it is and improve it no worries, let me know.

  1. When the component is editable and the code is edited, then after edition the code will be "doubled" (display twice, then fourth, etc.). I'll send you a video on twitter to display what I mean

  2. If lineNumbers if true then highlightLines is ignored. If possible it would be cool if both could work together

With lineNumbers:

Capture d’écran 2019-07-29 à 17 23 05

If I remove lineNumbers, highlight appears

Capture d’écran 2019-07-29 à 17 25 51

@peterpeterparker peterpeterparker merged commit 25d6804 into deckgo:master Jul 30, 2019

@peterpeterparker

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

Woohoo freaking awesome 👍

Thx for the PR @StefanNieuwenhuis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.