From f41125b5584d218245eb688aca08900b1bc866fd Mon Sep 17 00:00:00 2001 From: peterpeterparker Date: Thu, 27 Feb 2020 12:07:55 +0100 Subject: [PATCH 1/2] feat: rollback and release max-height to preserve aspect ratio Signed-off-by: peterpeterparker --- CHANGELOG.md | 2 +- webcomponents/slides/aspect-ratio/CHANGELOG.md | 8 ++++++++ webcomponents/slides/aspect-ratio/package-lock.json | 2 +- webcomponents/slides/aspect-ratio/package.json | 2 +- .../src/components/deckdeckgo-slide-aspect-ratio.scss | 1 - 5 files changed, 11 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 244b4ad02..98fdb0c77 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,7 +5,7 @@ ### New: Web Components - drag-resize-rotate: v1.0.0-beta.3 ([CHANGELOG](https://github.com/deckgo/deckdeckgo/blob/master/webcomponents/drag-resize-rotate/CHANGELOG.md)) -- slide-aspect-ratio: v1.0.0-beta.1-1 ([CHANGELOG](https://github.com/deckgo/deckdeckgo/blob/master/webcomponents/slides/aspect-ratio/CHANGELOG.md)) +- slide-aspect-ratio: v1.0.0-beta.1-2 ([CHANGELOG](https://github.com/deckgo/deckdeckgo/blob/master/webcomponents/slides/aspect-ratio/CHANGELOG.md)) ### New: Others diff --git a/webcomponents/slides/aspect-ratio/CHANGELOG.md b/webcomponents/slides/aspect-ratio/CHANGELOG.md index 4e91235dc..b2d97f431 100644 --- a/webcomponents/slides/aspect-ratio/CHANGELOG.md +++ b/webcomponents/slides/aspect-ratio/CHANGELOG.md @@ -1,3 +1,11 @@ + + +# 1.0.0-beta.1-2 (2020-02-27) + +### Features + +- rollback max-height in order to preserve ratio + # 1.0.0-beta.1-1 (2020-02-27) diff --git a/webcomponents/slides/aspect-ratio/package-lock.json b/webcomponents/slides/aspect-ratio/package-lock.json index 9968ba020..516f9e9e1 100644 --- a/webcomponents/slides/aspect-ratio/package-lock.json +++ b/webcomponents/slides/aspect-ratio/package-lock.json @@ -1,6 +1,6 @@ { "name": "@deckdeckgo/slide-aspect-ratio", - "version": "1.0.0-beta.1-1", + "version": "1.0.0-beta.1-2", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/webcomponents/slides/aspect-ratio/package.json b/webcomponents/slides/aspect-ratio/package.json index 7728b2ea9..a4567a223 100644 --- a/webcomponents/slides/aspect-ratio/package.json +++ b/webcomponents/slides/aspect-ratio/package.json @@ -1,6 +1,6 @@ { "name": "@deckdeckgo/slide-aspect-ratio", - "version": "1.0.0-beta.1-1", + "version": "1.0.0-beta.1-2", "description": "This template lets you display the content of a slide with the same aspect ratio regardless of the devices.", "main": "dist/index.js", "module": "dist/index.mjs", diff --git a/webcomponents/slides/aspect-ratio/src/components/deckdeckgo-slide-aspect-ratio.scss b/webcomponents/slides/aspect-ratio/src/components/deckdeckgo-slide-aspect-ratio.scss index 58fd97547..9f1682bbb 100644 --- a/webcomponents/slides/aspect-ratio/src/components/deckdeckgo-slide-aspect-ratio.scss +++ b/webcomponents/slides/aspect-ratio/src/components/deckdeckgo-slide-aspect-ratio.scss @@ -30,7 +30,6 @@ div.deckgo-aspect-ratio-container { (var(--slide-width) - var(--slide-padding-start, var(--slide-padding-start-default)) - var(--slide-padding-end, var(--slide-padding-end-default))) * 9 / 16 ); - max-height: 100%; overflow: visible; From b102d316354fc484c8de8a63865af410802df5f1 Mon Sep 17 00:00:00 2001 From: peterpeterparker Date: Thu, 27 Feb 2020 12:10:32 +0100 Subject: [PATCH 2/2] feat: user last aspect ratio slide Signed-off-by: peterpeterparker --- docs/package-lock.json | 6 +++--- docs/package.json | 2 +- remote/package-lock.json | 6 +++--- remote/package.json | 2 +- studio/package-lock.json | 6 +++--- studio/package.json | 2 +- 6 files changed, 12 insertions(+), 12 deletions(-) diff --git a/docs/package-lock.json b/docs/package-lock.json index 259f26dae..7c0da7f89 100644 --- a/docs/package-lock.json +++ b/docs/package-lock.json @@ -124,9 +124,9 @@ "integrity": "sha512-iJbdxSwVGlgm4obzbLycEnUlVGvXxAAc10jnUaFQINTAqT6J23ZUeEs2CcdJlsZoo/WHXzsZv+jIeSJ7mep5hw==" }, "@deckdeckgo/slide-aspect-ratio": { - "version": "1.0.0-beta.1-1", - "resolved": "https://registry.npmjs.org/@deckdeckgo/slide-aspect-ratio/-/slide-aspect-ratio-1.0.0-beta.1-1.tgz", - "integrity": "sha512-HnnSRQC0Hg3lVJlFEt/7MMAXMpbAkJEvPC1rC6EM9ubGBZ3lFuPR9PngUfG3Zj43gQ517IzQD7tIhFlbockYNA==", + "version": "1.0.0-beta.1-2", + "resolved": "https://registry.npmjs.org/@deckdeckgo/slide-aspect-ratio/-/slide-aspect-ratio-1.0.0-beta.1-2.tgz", + "integrity": "sha512-DP/86d6guXxSqz2io6He+Hs/u+AollnQtCHBfQQIo5CMA0v+ypxn5lU7qU9uMEA/IGUtnyh6rGlMil9qsyCfdw==", "requires": { "@deckdeckgo/slide-utils": "^1.0.0-rc.1-1", "@deckdeckgo/utils": "^1.0.0-rc.2" diff --git a/docs/package.json b/docs/package.json index 18f7809c7..b0c362408 100644 --- a/docs/package.json +++ b/docs/package.json @@ -22,7 +22,7 @@ "@deckdeckgo/inline-editor": "^1.0.0-rc.3-3", "@deckdeckgo/lazy-img": "^1.0.0-rc.3-2", "@deckdeckgo/qrcode": "^1.0.0-rc.1-1", - "@deckdeckgo/slide-aspect-ratio": "^1.0.0-beta.1-1", + "@deckdeckgo/slide-aspect-ratio": "^1.0.0-beta.1-2", "@deckdeckgo/slide-author": "^1.0.0-rc.3-2", "@deckdeckgo/slide-big-img": "^1.0.0-rc.1", "@deckdeckgo/slide-chart": "^1.0.0-rc.3", diff --git a/remote/package-lock.json b/remote/package-lock.json index 14d9f9479..e3e3aed16 100644 --- a/remote/package-lock.json +++ b/remote/package-lock.json @@ -105,9 +105,9 @@ "integrity": "sha512-tXYYu3K/v94UTSOKrm6pWlFYoDhMpVkRfMILvxdYx77hbgxCtSeUL/S1XXQ4N0YVAYnVlgaEtEfJkKP14nzNlw==" }, "@deckdeckgo/slide-aspect-ratio": { - "version": "1.0.0-beta.1-1", - "resolved": "https://registry.npmjs.org/@deckdeckgo/slide-aspect-ratio/-/slide-aspect-ratio-1.0.0-beta.1-1.tgz", - "integrity": "sha512-HnnSRQC0Hg3lVJlFEt/7MMAXMpbAkJEvPC1rC6EM9ubGBZ3lFuPR9PngUfG3Zj43gQ517IzQD7tIhFlbockYNA==", + "version": "1.0.0-beta.1-2", + "resolved": "https://registry.npmjs.org/@deckdeckgo/slide-aspect-ratio/-/slide-aspect-ratio-1.0.0-beta.1-2.tgz", + "integrity": "sha512-DP/86d6guXxSqz2io6He+Hs/u+AollnQtCHBfQQIo5CMA0v+ypxn5lU7qU9uMEA/IGUtnyh6rGlMil9qsyCfdw==", "requires": { "@deckdeckgo/slide-utils": "^1.0.0-rc.1-1", "@deckdeckgo/utils": "^1.0.0-rc.2" diff --git a/remote/package.json b/remote/package.json index 81c170bd1..4c5e5616c 100644 --- a/remote/package.json +++ b/remote/package.json @@ -23,7 +23,7 @@ "@deckdeckgo/lazy-img": "^1.0.0-rc.3-2", "@deckdeckgo/qrcode": "^1.0.0-rc.1-1", "@deckdeckgo/remote-utils": "^1.0.0-rc.1", - "@deckdeckgo/slide-aspect-ratio": "^1.0.0-beta.1-1", + "@deckdeckgo/slide-aspect-ratio": "^1.0.0-beta.1-2", "@deckdeckgo/slide-author": "^1.0.0-rc.3-2", "@deckdeckgo/slide-big-img": "^1.0.0-rc.1", "@deckdeckgo/slide-chart": "^1.0.0-rc.3", diff --git a/studio/package-lock.json b/studio/package-lock.json index 2ba6c8152..498e239b4 100644 --- a/studio/package-lock.json +++ b/studio/package-lock.json @@ -133,9 +133,9 @@ "integrity": "sha512-tXYYu3K/v94UTSOKrm6pWlFYoDhMpVkRfMILvxdYx77hbgxCtSeUL/S1XXQ4N0YVAYnVlgaEtEfJkKP14nzNlw==" }, "@deckdeckgo/slide-aspect-ratio": { - "version": "1.0.0-beta.1-1", - "resolved": "https://registry.npmjs.org/@deckdeckgo/slide-aspect-ratio/-/slide-aspect-ratio-1.0.0-beta.1-1.tgz", - "integrity": "sha512-HnnSRQC0Hg3lVJlFEt/7MMAXMpbAkJEvPC1rC6EM9ubGBZ3lFuPR9PngUfG3Zj43gQ517IzQD7tIhFlbockYNA==", + "version": "1.0.0-beta.1-2", + "resolved": "https://registry.npmjs.org/@deckdeckgo/slide-aspect-ratio/-/slide-aspect-ratio-1.0.0-beta.1-2.tgz", + "integrity": "sha512-DP/86d6guXxSqz2io6He+Hs/u+AollnQtCHBfQQIo5CMA0v+ypxn5lU7qU9uMEA/IGUtnyh6rGlMil9qsyCfdw==", "requires": { "@deckdeckgo/slide-utils": "^1.0.0-rc.1-1", "@deckdeckgo/utils": "^1.0.0-rc.2" diff --git a/studio/package.json b/studio/package.json index e10ed1d33..a19298163 100644 --- a/studio/package.json +++ b/studio/package.json @@ -25,7 +25,7 @@ "@deckdeckgo/lazy-img": "^1.0.0-rc.3-2", "@deckdeckgo/qrcode": "^1.0.0-rc.1-1", "@deckdeckgo/remote": "^1.0.0-rc.6", - "@deckdeckgo/slide-aspect-ratio": "^1.0.0-beta.1-1", + "@deckdeckgo/slide-aspect-ratio": "^1.0.0-beta.1-2", "@deckdeckgo/slide-author": "^1.0.0-rc.3-2", "@deckdeckgo/slide-chart": "^1.0.0-rc.3", "@deckdeckgo/slide-content": "^1.0.0-rc.1",