-
Notifications
You must be signed in to change notification settings - Fork 2
feat(dvcr): auto-cleanup for dvcr storage #1688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
diafour
merged 14 commits into
main
from
feat/dvcr/add-controller-to-cleanup-registry-on-schedule
Nov 21, 2025
Merged
feat(dvcr): auto-cleanup for dvcr storage #1688
diafour
merged 14 commits into
main
from
feat/dvcr/add-controller-to-cleanup-registry-on-schedule
Nov 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z9r5
previously approved these changes
Nov 13, 2025
c574929 to
899cc75
Compare
yaroslavborbat
previously requested changes
Nov 14, 2025
...tualization-artifact/pkg/controller/dvcr-maintenance/internal/service/provisioning_lister.go
Outdated
Show resolved
Hide resolved
...tualization-artifact/pkg/controller/dvcr-maintenance/internal/service/provisioning_lister.go
Outdated
Show resolved
Hide resolved
...tualization-artifact/pkg/controller/dvcr-maintenance/internal/service/provisioning_lister.go
Outdated
Show resolved
Hide resolved
...tualization-artifact/pkg/controller/dvcr-maintenance/internal/service/provisioning_lister.go
Outdated
Show resolved
Hide resolved
...tualization-artifact/pkg/controller/dvcr-maintenance/internal/service/provisioning_lister.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/dvcr-maintenance/internal/cleanup.go
Show resolved
Hide resolved
...lization-artifact/pkg/controller/dvcr-garbage-collection/internal/watcher/dvcr_deployment.go
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/dvcr-maintenance/types/const.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/dvcr-maintenance/internal/life_cycle.go
Outdated
Show resolved
Hide resolved
899cc75 to
ed4113c
Compare
Isteb4k
requested changes
Nov 18, 2025
images/virtualization-artifact/pkg/common/annotations/annotations.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/dvcr-maintenance/condition/deployment.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/dvcr-maintenance/condition/deployment.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/dvcr-maintenance/internal/life_cycle.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/service/dvcr_service.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/common/annotations/annotations.go
Outdated
Show resolved
Hide resolved
2fda947 to
a85fe35
Compare
Isteb4k
requested changes
Nov 21, 2025
b108429 to
5d8eab1
Compare
Contributor
|
Workflow has started. The target step completed with status: failure. |
Isteb4k
previously approved these changes
Nov 21, 2025
7d6c71e to
391f8ef
Compare
- Add dvcr-maintenance controller tht triggers on schedule and secret/dvcr-maintenance changes. - Sets Maintenance condition on deployment/dvcr with cleanup state. - Creates secret to start cleanup, deletes secret when cleanup is finished. - Add hook to switch deployment/dvcr into maintenance mode. - Add gc.schedule setting to specify schedule in the ModuleConfig. Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
…in spec.settings.dvcr.gc.schedule to run cleanup periodically. Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
…1689) - Cleanup is disabled by default, set schedule explicitly in spec.settings.dvcr.gc.schedule to run cleanup periodically. * feat(api): postpone image operations until dvcr maintenance finishes - Add postpone handler that runs before all other handlers. - VirtualDisk: postpone only disks with dataSource that requires import to dvcr first. - Add ProvisioningPostponed reason for Ready condition for vi/cvi/vd resources. * feat(core): add auto-cleanup and check for dvcr-cleaner (#1675) Add new commands to support auto-cleanup: - dvcr-cleaner gc auto-cleanup — compares images in registry and in cluster, removes manifests not found in cluster, runs garbage collect. - dvcr-cleaner gc check — jst compares images in registry and in cluster and prints images eligible to cleanup. --------- Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
391f8ef to
e3859c3
Compare
Isteb4k
approved these changes
Nov 21, 2025
4 tasks
This was referenced Nov 27, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A combination of 3 parts:
spec.dvcr.gc.schedulesetting to specify schedule in the ModuleConfig.Add new commands to support auto-cleanup:
Why do we need it, and what problem does it solve?
We need to periodically cleanup non-existent images in registry to free up storage space.
What is the expected result?
dvcr storage is cleaned up on schedule.
Checklist
Changelog entries