Skip to content

Add Kiro active prompt steering and appearance settings#1

Merged
declancowen merged 6 commits into
mainfrom
codex/kiro-provider-appearance-review
May 21, 2026
Merged

Add Kiro active prompt steering and appearance settings#1
declancowen merged 6 commits into
mainfrom
codex/kiro-provider-appearance-review

Conversation

@declancowen
Copy link
Copy Markdown
Owner

@declancowen declancowen commented May 20, 2026

Summary

  • adds Kiro active-prompt steering through the shared ACP adapter while keeping Kiro-specific _message/send wiring inside the Kiro adapter
  • keeps ACP stop/cancel lifecycle completion tied to provider session/prompt termination after session/cancel
  • always forwards ACP session/cancel for interrupt requests, including resumed/desynced sessions with no local active-prompt bookkeeping
  • adds appearance settings, chat typography controls, and the reviewed visual/theme updates
  • records the diff/architecture review in .reviews/kiro-provider-appearance-review.md

Review fixes

  • fixed active prompt registration order before turn.started
  • fixed UI acknowledgement for same-turn Kiro follow-up prompts
  • restored the disconnected-environment guard on the collapsed mobile composer send button
  • fixed Codex P1 feedback by removing local ACP prompt-completion synthesis on interrupt and adding a controlled-runtime regression test
  • fixed Codex P1 feedback by forwarding session/cancel even when local active prompt state is missing

Validation

  • bun fmt
  • bun lint (passes with 9 existing warnings)
  • bun run typecheck
  • bun run test src/provider/acp/StandardAcpAdapter.test.ts src/provider/Layers/CursorAdapter.test.ts src/provider/acp/AcpAdapterSupport.test.ts src/provider/acp/KiroAcpSupport.test.ts
  • bun run test src/components/ChatView.logic.test.ts
  • bun run test -- --configLoader runner src/settings.test.ts
  • bun run test -- --configLoader runner src/settings/DesktopClientSettings.test.ts
  • git diff --check

Copy link
Copy Markdown
Owner Author

@codex review

Please review this PR with extra attention to:

  • Kiro provider architecture staying isolated from generic provider hooks
  • ACP active-prompt steering and stop/cancel lifecycle correctness
  • upstream-sync safety for the Providers/settings architecture
  • regressions in chat send/stop behavior and appearance settings persistence

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b83cc43f2d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/server/src/provider/acp/StandardAcpAdapter.ts Outdated
Copy link
Copy Markdown
Owner Author

@codex review

Follow-up requested after addressing the previous P1 cancel lifecycle feedback. Please re-review the latest commit cc00a4b1, especially ACP interrupt behavior in StandardAcpAdapter: turn completion should now remain tied to session/prompt termination after session/cancel, with the controlled-runtime regression test covering the prior early-completion failure.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cc00a4b171

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/server/src/provider/acp/StandardAcpAdapter.ts Outdated
Copy link
Copy Markdown
Owner Author

@codex review

Follow-up requested after addressing the latest P1 cancel forwarding feedback. Please re-review 33128fea, especially StandardAcpAdapter.interruptTurn: it should always forward session/cancel, while turn completion still remains tied to session/prompt resolution when a local prompt is active. Regression coverage now includes both active-prompt cancellation and no-local-active-prompt cancellation.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner Author

@codex review

Follow-up requested after pushing b8c1c629, which extends Kiro active-turn steering to support attachments while preserving the shared ACP/provider boundary. Please re-review the latest head with attention to:

  • active prompt steering should not create a second session/prompt
  • image attachments sent during an active Kiro turn should route through the Kiro _message/send hook
  • ACP prompt lifecycle and interrupt/cancel fixes should remain intact
  • Kiro-specific private-method behavior should stay isolated in KiroAdapter

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner Author

@codex review

Please review the latest pushed changes on codex/kiro-provider-appearance-review at a31f8959df32ec9d2f5c3e666c924737ca8013de.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@declancowen declancowen merged commit b2e1c56 into main May 21, 2026
@declancowen declancowen deleted the codex/kiro-provider-appearance-review branch May 21, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant