Skip to content

Fix Kiro ACP stop and icon polish#2

Merged
declancowen merged 1 commit into
mainfrom
codex/kiro-acp-stop-icon-polish
May 21, 2026
Merged

Fix Kiro ACP stop and icon polish#2
declancowen merged 1 commit into
mainfrom
codex/kiro-acp-stop-icon-polish

Conversation

@declancowen
Copy link
Copy Markdown
Owner

Summary

  • preserve provider-owned ACP request IDs and permission option IDs for Kiro tool approvals
  • keep Kiro active-prompt steering on _message/send while making Stop close the Kiro ACP session when session/cancel is unsupported
  • refresh app icon assets with a more macOS-style rounded boundary and keep sidebar/send icon polish

Validation

  • bun --filter t3 test src/provider/acp/AcpRuntimeModel.test.ts src/provider/acp/AcpAdapterSupport.test.ts src/provider/acp/StandardAcpAdapter.test.ts
  • bun --filter effect-acp test src/client.test.ts src/protocol.test.ts
  • bun --filter @t3tools/web test src/components/Sidebar.logic.test.ts src/components/chat/ComposerPrimaryActions.test.ts src/components/ui/sidebar.test.tsx
  • bun fmt
  • bun lint
  • bun typecheck
  • git diff --check
  • bun run dist:desktop:dmg:arm64

@declancowen
Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@declancowen declancowen merged commit b041476 into main May 21, 2026
@declancowen declancowen deleted the codex/kiro-acp-stop-icon-polish branch May 21, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant