[codex] fix running composer steering send#3
Merged
Conversation
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the chat composer send path for running-thread steering/follow-up messages. The send boundary now reads the current Lexical editor snapshot through the composer handle and
ChatViewuses that fresh prompt directly. Model-only plan helper callers opt out of prompt syncing so cleared draft text is not reintroduced.Also records the local diff/architecture review for this change in
.reviews/chat-composer-steering-review.md.Root cause
The visible Lexical editor state could be newer than the parent
promptRef/draft state used byonSend, so Enter could appear to do nothing until a thread switch forced the composer state to resync.Validation
bun fmtbun lint(passes with existing warnings)bun typecheckgit diff --checkNotes
Preview In Root/is unrelated local untracked content and is intentionally not included.