Skip to content

[codex] fix running composer steering send#3

Merged
declancowen merged 1 commit into
mainfrom
codex/fix-running-composer-steering
May 21, 2026
Merged

[codex] fix running composer steering send#3
declancowen merged 1 commit into
mainfrom
codex/fix-running-composer-steering

Conversation

@declancowen
Copy link
Copy Markdown
Owner

Summary

Fixes the chat composer send path for running-thread steering/follow-up messages. The send boundary now reads the current Lexical editor snapshot through the composer handle and ChatView uses that fresh prompt directly. Model-only plan helper callers opt out of prompt syncing so cleared draft text is not reintroduced.

Also records the local diff/architecture review for this change in .reviews/chat-composer-steering-review.md.

Root cause

The visible Lexical editor state could be newer than the parent promptRef/draft state used by onSend, so Enter could appear to do nothing until a thread switch forced the composer state to resync.

Validation

  • bun fmt
  • bun lint (passes with existing warnings)
  • bun typecheck
  • git diff --check

Notes

Preview In Root/ is unrelated local untracked content and is intentionally not included.

@declancowen
Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@declancowen declancowen merged commit d59070c into main May 21, 2026
@declancowen declancowen deleted the codex/fix-running-composer-steering branch May 23, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant