Skip to content

[codex] Fix Kiro ACP image attachment errors#6

Merged
declancowen merged 3 commits into
mainfrom
codex/kiro-acp-image-errors
May 23, 2026
Merged

[codex] Fix Kiro ACP image attachment errors#6
declancowen merged 3 commits into
mainfrom
codex/kiro-acp-image-errors

Conversation

@declancowen
Copy link
Copy Markdown
Owner

Summary

  • Preserve ACP JSON-RPC error data so Kiro image failures surface as provider request errors instead of Effect decode defects.
  • Add ACP image prompt capability checks and Kiro MIME allowlist support for PNG/JPEG/GIF/WebP.
  • Address review findings for ACP request ID aliasing, shell env probing, desktop update recovery, release workflow refs, compact send rendering, and credentialed browser CORS.

Validation

  • bun run test src/client.test.ts src/protocol.test.ts from packages/effect-acp
  • bun run test src/provider/acp/StandardAcpAdapter.test.ts from apps/server
  • bun run --cwd apps/server test src/http.test.ts src/server.test.ts
  • bun fmt
  • bun lint
  • bun typecheck
  • bun run test

Review

  • Codex review on head 7d1ec6d2 completed with no major issues.

@github-actions github-actions Bot added size:XL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels May 23, 2026
@declancowen declancowen merged commit 0b8b9fd into main May 23, 2026
5 of 7 checks passed
@declancowen declancowen deleted the codex/kiro-acp-image-errors branch May 23, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant