blockchain: Max revocations in block sanity. #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
blockchain_validate_max_revocations_block_sanity
branch
from
3a81189
to
44b4f19
Compare
dnldd
approved these changes
Feb 15, 2018
davecgh
force-pushed
the
blockchain_validate_max_revocations_block_sanity
branch
2 times, most recently
from
17074fd
to
52666d8
Compare
alexlyp
approved these changes
Feb 15, 2018
This moves the check for validating that the number of revocations does not exceed the maximum allowed to the checkBlockSanity function where it more naturally belongs since it does not require access to any previous chain context. It should be noted that this check previously used math.MaxUint8 and was rather implicitly limited by the fact the header uses a uint8 for the field, so this makes the requirement more explicit by defining a constant.
davecgh
force-pushed
the
blockchain_validate_max_revocations_block_sanity
branch
from
52666d8
to
8eda558
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the check for validating that the number of revocations does not exceed the maximum allowed to the
checkBlockSanityfunction where it more naturally belongs since it does not require access to any previous chain context.It should be noted that this check previously used
math.MaxUint8and was rather implicitly limited by the fact the header uses auint8for the field, so this makes the requirement more explicit by defining a constant.